Gentoo Archives: gentoo-dev

From: Roy Marples <uberlord@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Modular texlive eclasses up for review
Date: Tue, 09 Oct 2007 07:26:43
Message-Id: 1191914011.2619.7.camel@uberpc.marples.name
In Reply to: Re: [gentoo-dev] Modular texlive eclasses up for review by Alexis Ballier
1 On Tue, 2007-10-09 at 01:03 +0200, Alexis Ballier wrote:
2 > On Mon, 8 Oct 2007 23:47:31 +0200
3 > Alexis Ballier <aballier@g.o> wrote:
4 >
5 > > Hi list,
6 >
7 >
8 > Try 2, after dberkholz comments on irc:
9 > - replaced test by []
10 > - removed useless use of cat
11 >
12 >
13 > Alexis.
14
15 grep '^!' "${i}" | tr ' ' '=' |sort|uniq >> "${T}/jobs"
16 Could be done with a 1 sed and 1 sort call, but whatever floats your
17 boat.
18
19 case ${command} in
20 Should quote command here
21
22 if [ "${f/config/}" != "${f}" ]
23 Should be
24 if [ "${f#*config*}" != "${f}" ]
25
26 return $([ -f "${mark}" ])
27 Could be written as
28 [ -f "${mark}" ]
29
30 Thanks
31
32 Roy
33
34 --
35 gentoo-dev@g.o mailing list

Replies

Subject Author
Re: [gentoo-dev] Modular texlive eclasses up for review Alexis Ballier <aballier@g.o>