Gentoo Archives: gentoo-dev

From: Daniel Campbell <zlg@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [PATCH 0/5] RFC: Patches for wxwidgets.eclass
Date: Thu, 04 Feb 2016 01:11:11
Message-Id: 56B2A464.3060507@gentoo.org
In Reply to: [gentoo-dev] Re: [PATCH 0/5] RFC: Patches for wxwidgets.eclass by Ryan Hill
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 02/02/2016 02:36 PM, Ryan Hill wrote:
5 > On Mon, 1 Feb 2016 12:08:28 +0100 Justin Lecher <jlec@g.o>
6 > wrote:
7 >
8 >> while tracking down the following error when running "egencache"
9 >>
10 >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command
11 >> not found GENTOO.GIT//eclass/wxwidgets.eclass: line 84:
12 >> get_libdir: command not found
13 >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command
14 >> not found GENTOO.GIT//eclass/wxwidgets.eclass: line 84:
15 >> get_libdir: command not found
16 >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command
17 >> not found GENTOO.GIT//eclass/wxwidgets.eclass: line 84:
18 >> get_libdir: command not found
19 >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command
20 >> not found GENTOO.GIT//eclass/wxwidgets.eclass: line 84:
21 >> get_libdir: command not found
22 >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command
23 >> not found
24 >>
25 >> I found that the global scope get_libdir() usage of the
26 >> wxwidgets.eclass doens't work on EAPI=6. The following patches
27 >> correct some minor things and block EAPI=6 for now until the
28 >> eclass is ready.
29 >>
30 >> Justin Lecher (5): wxwidgets.eclass: Update Copyright year
31 >> wxwidgets.eclass: Fix whitespaces wxwidgets.eclass: unset
32 >> unneeded variables in global scope after usage wxwidgets.eclass:
33 >> Only inherit eclass ones wxwidgets.eclass: Add EAPI support
34 >>
35 >> eclass/wxwidgets.eclass | 33 ++++++++++++++++++++++++--------- 1
36 >> file changed, 24 insertions(+), 9 deletions(-)
37 >>
38 >
39 > 1. I don't think most of this is necessary but go ahead I guess. 2.
40 > When did we start posting every @&#$! eclass change to g-dev? File
41 > a bug like a normal person. (There's already one open you could
42 > have used)
43 >
44 >
45
46 I see nothing wrong with discussing changes to parts of the tree that
47 will affect other developers. Bugzilla is nice and all, but imo it's
48 more of an AND thing instead of an OR thing. If the bug is already
49 present, I see no real reason not to have a thread about it on g-dev.
50 It keeps unrelated developers in the loop, as well, in the event that
51 they come across weird eclass behavior or take on a project using a
52 given eclass.
53
54 I guess if eclass discussion is a problem, one could always add a rule
55 to whatever they use to filter their mail.
56
57 - --
58 Daniel Campbell - Gentoo Developer
59 OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net
60 fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6
61 -----BEGIN PGP SIGNATURE-----
62 Version: GnuPG v2
63
64 iQIcBAEBCAAGBQJWsqRfAAoJEAEkDpRQOeFwMNEQAJTu8qR9PRV0yWOJpiUdNYXM
65 bdshcE17w41+xXSdDK+rhWxdQeZwG5fzxzqwtvzNr8lYtKPuTOaKRNV/KxjhBMH8
66 tiwIfggw0RfnKnlysQPXMB6YDrbkYAYZmRIObZBF9ZBhLqkod+HW2Ek0gLUfC1jP
67 3HIU6ymexHc+AGehw/L6FzQPGnv7SSDcTFqU8XI5HZZjT4M4xGdU9S3hM3kHFqOL
68 f8Ua/ygYnWgAe7XeR7pxC9N1wRZHUbBXEc+I8hQa0i3a0vM0j62c2xQZ/tF7/wwy
69 1ie/7ogU2+4CCAqXUU783I9HtZC+kGeNGPtuBMgQUlwJ96NavK7fxCvLRRejs+Pc
70 9AhPYSQcGF/abeqVxSib2QBnXUumWXWKKPNSqpVvKWgTjGhtE0HNjHHq+y5tv3pi
71 l7IlyK3eR4jGbDxxswUkFo0be1OU/LKP9jKM0nNB+GT3OT5Xu6qV2lDQIpAe3r/i
72 E1yGZXTe+WlfhVbtaz6KQKqa4wf9nF85JMu3lfwigAucxIbfrcMkXKEnrROq9qpw
73 5ouNyUTrbPgnap5v8JUMNmKp2PgR87v9ZUwtwum2w7FH5+qzGGGC+5dGnwC9JiUj
74 9G0ETBaUnMkqcTRAUyz9q+BHdgD9+ZWIfw3U4Db23YtDEtwwHcZgZDg2TA7Ch6jm
75 EY+h/UWs3jYNjT4ZTulx
76 =V736
77 -----END PGP SIGNATURE-----

Replies