| 1 |
On 2016-02-09 19:59, Robin H. Johnson wrote: |
| 2 |
>On Tue, Feb 09, 2016 at 07:03:28PM -0500, Tim Harder wrote: |
| 3 |
>> Just to note, devs that make these mistakes should already get emails from the |
| 4 |
>> CI test setup [1]. If those emails need to be more specific about the severity |
| 5 |
>> I'm sure that could be changed so you don't need to act like a CI bot if you |
| 6 |
>> don't want to. ;) |
| 7 |
>> [1]: https://archives.gentoo.org/gentoo-automated-testing/message/79a7b4fe2afaa71de9ef1189464f8324 |
| 8 |
>Well then raise the severity, because it's still blocking rsync as |
| 9 |
>nobody fixed it. |
| 10 |
> |
| 11 |
>I have reverted it now, so that rsync continues to propagate (it would |
| 12 |
>be nice if repoman manifest-check could be non-fatal about missing DIST |
| 13 |
>entries, but strict about everything else). |
| 14 |
|
| 15 |
I imagine in the end it would be better to put some of the faster checks |
| 16 |
into the git hook pipeline itself. For example, reject commits at push |
| 17 |
time that are missing DIST entries. |
| 18 |
|
| 19 |
Since I'm not familiar with the infra setup all I can do is provide |
| 20 |
support if it's feasible and someone wants to implement this using |
| 21 |
pkgcore/pkgcheck similar to what the CI stuff already does. |
| 22 |
|
| 23 |
Thanks, |
| 24 |
Tim |
Archives