1 |
On Sunday 30 March 2008, Mark Loeser wrote: |
2 |
> Donnie Berkholz <dberkholz@g.o> said: |
3 |
> > On 17:26 Sat 29 Mar , Mike Frysinger (vapier) wrote: |
4 |
> > > 1.1 sys-apps/iproute2/iproute2-2.6.24.20080108.ebuild |
5 |
> > > |
6 |
> > > file : |
7 |
> > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/iproute2/iprou |
8 |
> > >te2-2.6.24.20080108.ebuild?rev=1.1&view=markup plain: |
9 |
> > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/iproute2/iprou |
10 |
> > >te2-2.6.24.20080108.ebuild?rev=1.1&content-type=text/plain |
11 |
> > > |
12 |
> > > local check base=${PORTAGE_CONFIGROOT}/etc/portage/patches |
13 |
> > > for check in {${CATEGORY}/${PF},${CATEGORY}/${P},${CATEGORY}/${PN}}; |
14 |
> > > do EPATCH_SOURCE=${base}/${CTARGET}/${check} |
15 |
> > > [[ -r ${EPATCH_SOURCE} ]] || EPATCH_SOURCE=${base}/${CHOST}/${check} |
16 |
> > > [[ -r ${EPATCH_SOURCE} ]] || EPATCH_SOURCE=${base}/${check} |
17 |
> > > if [[ -d ${EPATCH_SOURCE} ]] ; then |
18 |
> > > EPATCH_SUFFIX="patch" |
19 |
> > > EPATCH_FORCE="yes" \ |
20 |
> > > EPATCH_MULTI_MSG="Applying user patches from ${EPATCH_SOURCE} ..." \ |
21 |
> > > epatch |
22 |
> > > break |
23 |
> > > fi |
24 |
> > > done |
25 |
> > |
26 |
> > This looks like it should be generic code somewhere else. |
27 |
> |
28 |
> Actually, I'd say this should just be removed. If a user wants to apply |
29 |
> a patch, they can put their own ebuild into an overlay and do it |
30 |
> themselves (presumably if they want to patch something, they'll know how |
31 |
> to make the simple modifications to an ebuild). By allowing the user to |
32 |
> arbitrarily patch something means we have no idea what the user has |
33 |
> built and is filing a bug about. If they installed an ebuild from an |
34 |
> overlay it is a lot easier to identify what they built. Sure, they |
35 |
> could patch the ebuild in their tree, but by supporting user supplied |
36 |
> patches easily in this way, we are encouraging them to patch things |
37 |
> without our knowledge. If we start supporting this across the board, I |
38 |
> can see bugs being filed when their patches break and they don't |
39 |
> understand what is happening. |
40 |
|
41 |
that's actually exactly what i'm encouraging. i'm not worried about such |
42 |
issues as they're easily resolved by people posting the full build log. |
43 |
-mike |