Gentoo Archives: gentoo-dev

From: Mark Loeser <halcy0n@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/iproute2: ChangeLog iproute2-2.6.24.20080108.ebuild
Date: Sun, 30 Mar 2008 21:18:54
Message-Id: 20080330211844.GB32327@aerie.halcy0n.com
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/iproute2: ChangeLog iproute2-2.6.24.20080108.ebuild by Mike Frysinger
1 Mike Frysinger <vapier@g.o> said:
2 > On Sunday 30 March 2008, Mark Loeser wrote:
3 > > Actually, I'd say this should just be removed. If a user wants to apply
4 > > a patch, they can put their own ebuild into an overlay and do it
5 > > themselves (presumably if they want to patch something, they'll know how
6 > > to make the simple modifications to an ebuild). By allowing the user to
7 > > arbitrarily patch something means we have no idea what the user has
8 > > built and is filing a bug about. If they installed an ebuild from an
9 > > overlay it is a lot easier to identify what they built. Sure, they
10 > > could patch the ebuild in their tree, but by supporting user supplied
11 > > patches easily in this way, we are encouraging them to patch things
12 > > without our knowledge. If we start supporting this across the board, I
13 > > can see bugs being filed when their patches break and they don't
14 > > understand what is happening.
15 >
16 > that's actually exactly what i'm encouraging. i'm not worried about such
17 > issues as they're easily resolved by people posting the full build log.
18
19 Which is great, but I think this is something we should discuss and
20 figure out if this is something we want to introduce into the tree (too
21 late now, but better late than never). If it is something we want to
22 move forward with, it should be introduced at the package manager level
23 instead of being an in-tree package manager specific feature.
24
25 I'm coming at this from a QA perspective and if we want to do it for one
26 package, it should be introduced for all. We should document it and
27 know how to support it as well.
28
29 Thanks,
30
31 --
32 Mark Loeser
33 email - halcy0n AT gentoo DOT org
34 email - mark AT halcy0n DOT com
35 web - http://www.halcy0n.com

Replies