| 1 |
On Sunday 30 March 2008, Mark Loeser wrote: |
| 2 |
> Mike Frysinger <vapier@g.o> said: |
| 3 |
> > On Sunday 30 March 2008, Mark Loeser wrote: |
| 4 |
> > > Actually, I'd say this should just be removed. If a user wants to |
| 5 |
> > > apply a patch, they can put their own ebuild into an overlay and do it |
| 6 |
> > > themselves (presumably if they want to patch something, they'll know |
| 7 |
> > > how to make the simple modifications to an ebuild). By allowing the |
| 8 |
> > > user to arbitrarily patch something means we have no idea what the user |
| 9 |
> > > has built and is filing a bug about. If they installed an ebuild from |
| 10 |
> > > an overlay it is a lot easier to identify what they built. Sure, they |
| 11 |
> > > could patch the ebuild in their tree, but by supporting user supplied |
| 12 |
> > > patches easily in this way, we are encouraging them to patch things |
| 13 |
> > > without our knowledge. If we start supporting this across the board, I |
| 14 |
> > > can see bugs being filed when their patches break and they don't |
| 15 |
> > > understand what is happening. |
| 16 |
> > |
| 17 |
> > that's actually exactly what i'm encouraging. i'm not worried about such |
| 18 |
> > issues as they're easily resolved by people posting the full build log. |
| 19 |
> |
| 20 |
> Which is great, but I think this is something we should discuss and |
| 21 |
> figure out if this is something we want to introduce into the tree (too |
| 22 |
> late now, but better late than never). If it is something we want to |
| 23 |
> move forward with, it should be introduced at the package manager level |
| 24 |
> instead of being an in-tree package manager specific feature. |
| 25 |
> |
| 26 |
> I'm coming at this from a QA perspective and if we want to do it for one |
| 27 |
> package, it should be introduced for all. We should document it and |
| 28 |
> know how to support it as well. |
| 29 |
|
| 30 |
there is no package-manager specificness here. it's already completely doable |
| 31 |
from a user perspective, just having it in the ebuild makes my life and |
| 32 |
users' lives easier. i'm using it in packages that tend to have a lot of |
| 33 |
extraneous patchsets associated with them. the random patches were punted |
| 34 |
from ebuilds and now it's up to the user to maintain the feature sets. |
| 35 |
-mike |
Archives