[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-dns/bind/files/, net-dns/bind/

[Pacho Ramos]

El dom, 04-10-2015 a las 11:34 +0200, hasufell escribió:
> On 10/04/2015 10:29 AM, Pacho Ramos wrote:
> > commit:     7f2d82c0ec3bea388511cf190c7426fa2815ea89
> > Author:     Pacho Ramos <pacho <AT> gentoo <DOT> org>
> > AuthorDate: Sun Oct  4 08:28:58 2015 +0000
> > Commit:     Pacho Ramos <pacho <AT> gentoo <DOT> org>
> > CommitDate: Sun Oct  4 08:28:58 2015 +0000
> > URL:
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f2d82c0
> >
> > net-dns/bind: Install missing tmpfiles.d file (#559118 by Alexey
> > Sychev)
> >
> > Package-Manager: portage-2.2.22
> >
> >  net-dns/bind/bind-9.10.2_p4-r1.ebuild | 408
> > ++++++++++++++++++++++++++++++++++
> >  net-dns/bind/files/named.conf         |   1 +
> >  2 files changed, 409 insertions(+)
> >
> > diff --git a/net-dns/bind/bind-9.10.2_p4-r1.ebuild b/net
> > -dns/bind/bind-9.10.2_p4-r1.ebuild
> > new file mode 100644
> > index 0000000..68ccb97
> > --- /dev/null
> > +++ b/net-dns/bind/bind-9.10.2_p4-r1.ebuild
>
> [...]
> > +DEPEND="ssl? ( dev-libs/openssl:0[-bindist] )
> > + mysql? ( >=virtual/mysql-4.0 )
> > + odbc? ( >=dev-db/unixODBC-2.2.6 )
> > + ldap? ( net-nds/openldap )
> > + idn? ( net-dns/idnkit )
> > + postgres? ( dev-db/postgresql:= )
> > + caps? ( >=sys-libs/libcap-2.1.0 )
> > + xml? ( dev-libs/libxml2 )
> > + geoip? ( >=dev-libs/geoip-1.4.6 )
> > + gssapi? ( virtual/krb5 )
> > + gost? ( >=dev-libs/openssl-1.0.0:0[-bindist] )
> > + seccomp? ( sys-libs/libseccomp )
> > + json? ( dev-libs/json-c )"
> > +# sdb-ldap? ( net-nds/openldap )
> > +
> > +RDEPEND="${DEPEND}
> > + selinux? ( sec-policy/selinux-bind )
> > + || ( sys-process/psmisc >=sys-freebsd/freebsd-ubin-9.0_rc sys
> > -process/fuser-bsd )"
>
> ${PYTHON_DEPS} is missing here, even if python USE flag is enabled.
> Is
> that on purpose? This packages uses python-r1 so no python deps will
> be
> automagically added.
>
> [...]
> > +
> > +	if use nslint; then
> > +		cd $NSLINT_DIR
>
> missing || die
>
> [...]
> > +
> > +src_install() {
> > +	emake DESTDIR="${D}" install
> > +
> > +	if use nslint; then
> > +		cd $NSLINT_DIR
>
> missing || die
>
> [...]
> > +		dobin nslint
> > +		doman nslint.8
> > +		cd "${S}"
>
> missing || die
>
> [...]
> > +
> > +		# some handy-dandy dynamic dns examples
> > +		pushd "${D}"/usr/share/doc/${PF} 1>/dev/null
>
> missing || die on pushd/popd
>
> > +		tar xf "${DISTDIR}"/dyndns-samples.tbz2 || die
> > +		popd 1>/dev/null
> > +	fi
> > +
>
Please report to the right people, you can simply diff between the
ebuilds to see that I only touched the relevant systemd part. You can
also, of course, do the same as I needed to do for systemd part and go
ahead fixing the dies instead of trying to blame on me by the sake of
it.