Archives
Archives
| From: | Mike Gilbert <floppym@g.o> | ||
|---|---|---|---|
| To: | Gentoo Dev <gentoo-dev@l.g.o> | ||
| Subject: | Re: [gentoo-dev] [PATCH] linux-info.eclass: get_version: remove useless readlink -f | ||
| Date: | Wed, 30 Nov 2016 16:45:47 | ||
| Message-Id: | CAJ0EP41cwCUCY2kKL09Xaf4uE_A8gyDNv_Xo3HRcF0H_91MA4w@mail.gmail.com | ||
| In Reply to: | Re: [gentoo-dev] [PATCH] linux-info.eclass: get_version: remove useless readlink -f by Michael Orlitzky |
||
| 1 | On Wed, Nov 30, 2016 at 11:28 AM, Michael Orlitzky <mjo@g.o> wrote: |
| 2 | > On 11/26/2016 12:47 PM, Mike Gilbert wrote: |
| 3 | >> The values get clobbered immediately afterward, so why bother? |
| 4 | >> ... |
| 5 | >> qeinfo "Determining the location of the kernel source code" |
| 6 | >> - [ -h "${KERNEL_DIR}" ] && KV_DIR="$(readlink -f ${KERNEL_DIR})" |
| 7 | >> [ -d "${KERNEL_DIR}" ] && KV_DIR="${KERNEL_DIR}" |
| 8 | >> |
| 9 | > |
| 10 | > This changes the behavior if $KERNEL_DIR is a symbolic link to a |
| 11 | > nonexistent directory, doesn't it? |
| 12 | |
| 13 | Yes, I suppose it does. Do you anticipate that will cause a problem? |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH] linux-info.eclass: get_version: remove useless readlink -f | Michael Orlitzky <mjo@g.o> |