Gentoo Archives: gentoo-dev

From: Michael Orlitzky <mjo@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] linux-info.eclass: get_version: remove useless readlink -f
Date: Wed, 30 Nov 2016 16:29:41
Message-Id: a7551ce9-95b4-4528-5356-76d42200be17@gentoo.org
In Reply to: [gentoo-dev] [PATCH] linux-info.eclass: get_version: remove useless readlink -f by Mike Gilbert
1 On 11/26/2016 12:47 PM, Mike Gilbert wrote:
2 > The values get clobbered immediately afterward, so why bother?
3 > ...
4 > qeinfo "Determining the location of the kernel source code"
5 > - [ -h "${KERNEL_DIR}" ] && KV_DIR="$(readlink -f ${KERNEL_DIR})"
6 > [ -d "${KERNEL_DIR}" ] && KV_DIR="${KERNEL_DIR}"
7 >
8
9 This changes the behavior if $KERNEL_DIR is a symbolic link to a
10 nonexistent directory, doesn't it?

Replies