Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-dev@l.g.o
Cc: kernel@g.o
Subject: [gentoo-dev] [PATCH] linux-info.eclass: get_version: remove useless readlink -f
Date: Sat, 26 Nov 2016 17:47:53
Message-Id: 20161126174742.19488-1-floppym@gentoo.org
1 The values get clobbered immediately afterward, so why bother?
2 ---
3 eclass/linux-info.eclass | 2 --
4 1 file changed, 2 deletions(-)
5
6 diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
7 index 16740a3126fb..0dc7b0d0027b 100644
8 --- a/eclass/linux-info.eclass
9 +++ b/eclass/linux-info.eclass
10 @@ -445,7 +445,6 @@ get_version() {
11 # KV_DIR will contain the full path to the sources directory we should use
12 [ -z "${get_version_warning_done}" ] && \
13 qeinfo "Determining the location of the kernel source code"
14 - [ -h "${KERNEL_DIR}" ] && KV_DIR="$(readlink -f ${KERNEL_DIR})"
15 [ -d "${KERNEL_DIR}" ] && KV_DIR="${KERNEL_DIR}"
16
17 if [ -z "${KV_DIR}" ]
18 @@ -539,7 +538,6 @@ get_version() {
19 done
20 fi
21
22 - [ -h "${OUTPUT_DIR}" ] && KV_OUT_DIR="$(readlink -f ${OUTPUT_DIR})"
23 [ -d "${OUTPUT_DIR}" ] && KV_OUT_DIR="${OUTPUT_DIR}"
24 if [ -n "${KV_OUT_DIR}" ];
25 then
26 --
27 2.11.0.rc2

Replies