Gentoo Archives: gentoo-dev

From: "Anthony G. Basile" <blueness@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC: pax-utils.eclass, downgrade from elog to einfo to avoid flooding logs
Date: Fri, 06 Apr 2012 17:57:59
Message-Id: 4F7F2E56.60001@gentoo.org
In Reply to: [gentoo-dev] RFC: pax-utils.eclass, downgrade from elog to einfo to avoid flooding logs by "Anthony G. Basile"
1 Okay no feedback. I'm assuming no one had any issues. I'm committing.
2
3 On 04/03/2012 09:55 AM, Anthony G. Basile wrote:
4 > Hi everyone,
5 >
6 > pax-utils.eclass generates a lot of log messages when marking a large
7 > number of files, for example icedtea-bin. These messages are not that
8 > useful, so I propose downgrading all elog's to einfo's to avoid
9 > flooding. See bug #407503. If there are no objections, I'll commit
10 > the following in a few days:
11 >
12 > --- pax-utils.eclass.orig 2012-04-03 09:29:41.000000000 -0400
13 > +++ pax-utils.eclass 2012-04-03 09:30:49.000000000 -0400
14 > @@ -58,8 +58,8 @@
15 > # Try paxctl, then scanelf. paxctl is preferred.
16 > if type -p paxctl> /dev/null&& has PT ${PAX_MARKINGS}; then
17 > # Try paxctl, the upstream supported tool.
18 > - elog "PT PaX marking -${flags}"
19 > - _pax_list_files elog "$@"
20 > + einfo "PT PaX marking -${flags}"
21 > + _pax_list_files einfo "$@"
22 > for f in "$@"; do
23 > # First, try modifying the existing PAX_FLAGS header
24 > paxctl -q${flags} "${f}"&& continue
25 > @@ -91,8 +91,8 @@
26 > elif type -p scanelf> /dev/null&& [[ ${PAX_MARKINGS} != "none"
27 > ]]; then
28 > # Try scanelf, the Gentoo swiss-army knife ELF utility
29 > # Currently this sets PT if it can, no option to control what
30 > it does.
31 > - elog "Fallback PaX marking -${flags}"
32 > - _pax_list_files elog "$@"
33 > + einfo "Fallback PaX marking -${flags}"
34 > + _pax_list_files einfo "$@"
35 > scanelf -Xxz ${flags} "$@"
36 > elif [[ ${PAX_MARKINGS} != "none" ]]; then
37 > # Out of options!
38 >
39 >
40 >
41
42
43 --
44 Anthony G. Basile, Ph.D.
45 Gentoo Linux Developer [Hardened]
46 E-Mail : blueness@g.o
47 GnuPG FP : 8040 5A4D 8709 21B1 1A88 33CE 979C AF40 D045 5535
48 GnuPG ID : D0455535