| 1 |
Christian Faulhammer schrieb: |
| 2 |
> Hi, |
| 3 |
> |
| 4 |
> welcome to your mentor reviews. :) |
| 5 |
> |
| 6 |
> "Heath Caldwell (hncaldwell)" <hncaldwell@g.o>: |
| 7 |
> |
| 8 |
>> Index: metadata.xml |
| 9 |
>> <flag name="kakasi"> |
| 10 |
>> Enable <pkg>app-i18n/kakasi</pkg> support for |
| 11 |
>> furigana generation </flag> |
| 12 |
> |
| 13 |
> I tend to call it furigana instead of kakasi, as USE flags should |
| 14 |
> describe a purpose/function not the needed software to achieve it. |
| 15 |
> |
| 16 |
>> Index: anki-0.9.8.1.ebuild |
| 17 |
>> =================================================================== |
| 18 |
>> # Copyright 1999-2008 Gentoo Foundation |
| 19 |
>> # Distributed under the terms of the GNU General Public License v2 |
| 20 |
>> # |
| 21 |
>> $Header: /var/cvsroot/gentoo-x86/app-misc/anki/anki-0.9.8.1.ebuild,v |
| 22 |
>> 1.1 2008/10/02 23:13:39 hncaldwell Exp $ |
| 23 |
>> |
| 24 |
>> EAPI=1 |
| 25 |
>> |
| 26 |
>> NEED_PYTHON=2.4 |
| 27 |
>> inherit eutils multilib python |
| 28 |
>> |
| 29 |
>> DESCRIPTION="A spaced-repetition memory training program (flash |
| 30 |
>> cards)" HOMEPAGE="http://ichi2.net/anki/index.html" |
| 31 |
>> SRC_URI="http://ichi2.net/anki/download/${P}.tgz" |
| 32 |
>> LICENSE="GPL-3" |
| 33 |
>> SLOT="0" |
| 34 |
>> KEYWORDS="~amd64 ~x86" |
| 35 |
>> IUSE="+graph kakasi +sound" |
| 36 |
>> |
| 37 |
>> RDEPEND=">=dev-python/PyQt4-4.3 |
| 38 |
>> >=dev-python/sqlalchemy-0.4.1 |
| 39 |
>> >=dev-python/simplejson-1.7.3 |
| 40 |
>> >=dev-python/pysqlite-2.3.0 |
| 41 |
> |
| 42 |
> pysqlite is included with Python 2.5 (USE=sqlite enabled), so you |
| 43 |
> might upgrade to EAPI=2 and use USE dependencies or add a |
| 44 |
> built_with_use check into pkg_config. Or ask the Python team how to |
| 45 |
> handle it in the best way. |
| 46 |
> |
| 47 |
>> src_install() { |
| 48 |
>> dodoc CREDITS |
| 49 |
>> |
| 50 |
>> python_version |
| 51 |
>> |
| 52 |
>> insinto "/usr/$(get_libdir)/python${PYVER}/site-packages" |
| 53 |
>> doins -r ankiqt libanki/anki |
| 54 |
>> |
| 55 |
>> insinto "/usr/$(get_libdir)/python${PYVER}/site-packages/anki" |
| 56 |
>> doins -r designer icons icons.qrc icons_rc.py libanki/samples |
| 57 |
>> |
| 58 |
>> dobin ${PN} |
| 59 |
>> |
| 60 |
>> doicon icons/${PN}.png |
| 61 |
>> make_desktop_entry ${PN} ${PN} ${PN}.png "Education" |
| 62 |
>> } |
| 63 |
> |
| 64 |
> No installation routine available? |
| 65 |
> |
| 66 |
> V-Li |
| 67 |
> |
| 68 |
|
| 69 |
Imho you should also add a " || die" to at least all functions that add nesessary files to run the |
| 70 |
app, so probably at least the first "doins -r" and "dobin". |
| 71 |
|
| 72 |
-- |
| 73 |
Thomas Sachau |
| 74 |
|
| 75 |
Gentoo Linux Developer |
Archives