Gentoo Archives: gentoo-dev

From: Justin <jlec@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
Date: Wed, 22 Feb 2012 18:44:56
Message-Id: 4F453758.1020304@gentoo.org
In Reply to: Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737) by Matthew Summers
1 On 22.02.2012 18:33, Matthew Summers wrote:
2 > On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@g.o> wrote:
3 >> Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
4 >>> Hi,
5 >>>
6 >>> any objections against following patch for subversion.eclass?
7 >>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during
8 >>> reemerge of a package.
9 >>>
10 >>>
11 >>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200
12 >>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200
13 >>> @@ -469,7 +469,9 @@
14 >>> local target="${1}"
15 >>> local key="${2}"
16 >>>
17 >>> - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2-
18 >>> + env LC_ALL=C svn info \
19 >>> + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \
20 >>> + "${target}" | grep -i "^${key}" | cut -d" " -f2-
21 >>> }
22 >>>
23 >>> ## -- subversion__get_repository_uri()
24 >>> --------------------------------------- #
25 >>
26 >> I'm not an expert of the subversion eclass, but the diff looks good.
27 >>
28 >> --
29 >> Gilles Dartiguelongue <eva@g.o>
30 >> Gentoo
31 >
32 > Why would you want a password in an ebuild? The var ESVN_PASSWORD
33 > seems like trouble to me.
34 >
35
36 This one for example
37
38 http://rapidsvn.tigris.org/
39
40 Quote:
41
42 Now you can checkout the source code for RapidSVN with RapidSVN
43 (Repository->Checkout) or with the svn command-line client.
44 The URL for the latest code is:
45 http://rapidsvn.tigris.org/svn/rapidsvn/trunk
46 You will be prompted for username and password.
47 For read access enter "guest" with an empty password.
48
49 justin

Attachments

File name MIME type
signature.asc application/pgp-signature