| 1 |
On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@g.o> wrote: |
| 2 |
> Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit : |
| 3 |
>> Hi, |
| 4 |
>> |
| 5 |
>> any objections against following patch for subversion.eclass? |
| 6 |
>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during |
| 7 |
>> reemerge of a package. |
| 8 |
>> |
| 9 |
>> |
| 10 |
>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200 |
| 11 |
>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200 |
| 12 |
>> @@ -469,7 +469,9 @@ |
| 13 |
>> local target="${1}" |
| 14 |
>> local key="${2}" |
| 15 |
>> |
| 16 |
>> - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2- |
| 17 |
>> + env LC_ALL=C svn info \ |
| 18 |
>> + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \ |
| 19 |
>> + "${target}" | grep -i "^${key}" | cut -d" " -f2- |
| 20 |
>> } |
| 21 |
>> |
| 22 |
>> ## -- subversion__get_repository_uri() |
| 23 |
>> --------------------------------------- # |
| 24 |
> |
| 25 |
> I'm not an expert of the subversion eclass, but the diff looks good. |
| 26 |
> |
| 27 |
> -- |
| 28 |
> Gilles Dartiguelongue <eva@g.o> |
| 29 |
> Gentoo |
| 30 |
|
| 31 |
Why would you want a password in an ebuild? The var ESVN_PASSWORD |
| 32 |
seems like trouble to me. |
| 33 |
|
| 34 |
-- |
| 35 |
Matthew W. Summers |
| 36 |
Gentoo Foundation Inc. |
Archives