Gentoo Archives: gentoo-dev

From: Gilles Dartiguelongue <eva@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)
Date: Tue, 21 Feb 2012 22:15:09
Message-Id: 1329862452.25132.0.camel@keitaro
In Reply to: [gentoo-dev] RFC patch for subversion.eclass (bug 401737) by Justin
1 Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
2 > Hi,
3 >
4 > any objections against following patch for subversion.eclass?
5 > Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during
6 > reemerge of a package.
7 >
8 >
9 > --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200
10 > +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200
11 > @@ -469,7 +469,9 @@
12 > local target="${1}"
13 > local key="${2}"
14 >
15 > - env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2-
16 > + env LC_ALL=C svn info \
17 > + ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \
18 > + "${target}" | grep -i "^${key}" | cut -d" " -f2-
19 > }
20 >
21 > ## -- subversion__get_repository_uri()
22 > --------------------------------------- #
23
24 I'm not an expert of the subversion eclass, but the diff looks good.
25
26 --
27 Gilles Dartiguelongue <eva@g.o>
28 Gentoo

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737) Matthew Summers <quantumsummers@g.o>