| 1 |
On Sat, Jun 17, 2006 at 12:35:30AM -0400, Thomas Cort wrote: |
| 2 |
> What is the proper quoting style for using epatch? In the tree there |
| 3 |
> are about 3 different styles... |
| 4 |
> |
| 5 |
> epatch ${FILESDIR}/some-fix.patch # used by 7326 ebuilds |
| 6 |
> epatch "${FILESDIR}"/some-fix.patch # used by 3092 ebuilds |
| 7 |
> epatch "${FILESDIR}/some-fix.patch" # used by 1434 ebuilds |
| 8 |
|
| 9 |
${FILESDIR} should be quoted, but as long as there are no wildcards in |
| 10 |
the "/some-fix.patch", it doesn't matter whether that is. |
| 11 |
|
| 12 |
> What is the proper quoting style for defining the S variable? In the |
| 13 |
> tree there are about 3 different styles... |
| 14 |
> |
| 15 |
> S=${WORKDIR}/${MY_P} # used by 5270 ebuilds |
| 16 |
> S="${WORKDIR}"/${MY_P} # used by 43 ebuilds |
| 17 |
> S="${WORKDIR}/${MY_P}" # used by 2259 ebuilds |
| 18 |
|
| 19 |
Any is fine, there is no word splitting or wildcard expansion in |
| 20 |
shell variable assignments. |
| 21 |
|
| 22 |
> What is the purpose of setting DEPEND and RDEPEND to "" if DEPEND and |
| 23 |
> RDEPEND are optional[1][2]? Isn't that just a waste of disk space / |
| 24 |
> bandwidth? |
| 25 |
|
| 26 |
RDEPEND defaults to DEPEND (in ebuilds), so if DEPEND is set, and |
| 27 |
RDEPEND should be empty, then RDEPEND must be set to "" explicitly. |
| 28 |
As for DEPEND="", that's mostly a stylistic issue, I think. |
| 29 |
|
| 30 |
> DEPEND="virtual/libc" seems like a waste too as it is an |
| 31 |
> implicit system dependency[3], any reason for using it? |
| 32 |
|
| 33 |
Not really. |
| 34 |
-- |
| 35 |
gentoo-dev@g.o mailing list |
Archives