Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-ros/compressed_image_transport/
Date: Fri, 09 Oct 2015 17:22:38
Message-Id: 20151009192221.51d7c0c9@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-ros/compressed_image_transport/ by hasufell
1 On Fri, 9 Oct 2015 19:18:49 +0200
2 hasufell <hasufell@g.o> wrote:
3
4 > On 10/09/2015 06:37 PM, Alexis Ballier wrote:
5 > > commit: 4440cc9d950795eaae8f8b049bbf37c073ef5ea0
6 > > Author: Alexis Ballier <aballier <AT> gentoo <DOT> org>
7 > > AuthorDate: Fri Oct 9 16:37:18 2015 +0000
8 > > Commit: Alexis Ballier <aballier <AT> gentoo <DOT> org>
9 > > CommitDate: Fri Oct 9 16:37:18 2015 +0000
10 > > URL:
11 > > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4440cc9d
12 > >
13 > > dev-ros/compressed_image_transport: Add PYTHON_COMPAT and
14 > > PYTHON_USEDEP on dynamic_reconfigure. Bug #562664.
15 > >
16 > > Package-Manager: portage-2.2.23
17 > >
18 >
19 > [...]
20 >
21 > > ---
22 > > a/dev-ros/compressed_image_transport/compressed_image_transport-1.9.2.ebuild
23 > > +++
24 > > b/dev-ros/compressed_image_transport/compressed_image_transport-1.9.2-r1.ebuild
25 > > @@ -6,6 +6,7 @@ EAPI=5
26 > > ROS_REPO_URI="https://github.com/ros-perception/image_transport_plugins"
27 > > KEYWORDS="~amd64 ~arm" ROS_SUBDIR=${PN} +PYTHON_COMPAT=( python2_7 )
28 > >
29 > > inherit ros-catkin
30 > >
31 > > @@ -16,7 +17,7 @@ IUSE=""
32 > >
33 > > RDEPEND="
34 > > dev-ros/cv_bridge
35 > > - dev-ros/dynamic_reconfigure
36 > > + dev-ros/dynamic_reconfigure[${PYTHON_USEDEP}]
37 > > dev-ros/image_transport
38 > > dev-ros/tf
39 > > media-libs/opencv
40 > >
41 > > diff --git
42 > > a/dev-ros/compressed_image_transport/compressed_image_transport-9999.ebuild
43 > > b/dev-ros/compressed_image_transport/compressed_image_transport-9999.ebuild
44 > > index f7a387a..144fac9 100644 ---
45 > > a/dev-ros/compressed_image_transport/compressed_image_transport-9999.ebuild
46 > > +++
47 > > b/dev-ros/compressed_image_transport/compressed_image_transport-9999.ebuild
48 > > @@ -6,6 +6,7 @@ EAPI=5
49 > > ROS_REPO_URI="https://github.com/ros-perception/image_transport_plugins"
50 > > KEYWORDS="~amd64 ~arm" ROS_SUBDIR=${PN} +PYTHON_COMPAT=( python2_7
51 > > ) inherit ros-catkin
52 > >
53 > > @@ -16,7 +17,7 @@ IUSE=""
54 > >
55 > > RDEPEND="
56 > > dev-ros/cv_bridge
57 > > - dev-ros/dynamic_reconfigure
58 > > + dev-ros/dynamic_reconfigure[${PYTHON_USEDEP}]
59 > > dev-ros/image_transport
60 > > dev-ros/tf
61 > > media-libs/opencv
62 > >
63 >
64 > Maybe I am missing something, but ${PYTHON_DEPS} seems missing here
65 > and I cannot find it in ros-catkin.eclass either. It's only an
66 > indirect dep which is inappropriate.
67
68
69 Doesn't python-r1 add this ? It seems not...
70 It should be added to ros-catkin.eclass when PYTHON_COMPAT is set. Any
71 hint on how to proceed ?

Replies