Re: [gentoo-dev] [PATCH 2/2] multilib-minimal.eclass: use run_in_build_dir().

[Michał Górny]

Dnia 2014-10-23, o godz. 22:31:39
Davide Pesavento <pesa@g.o> napisał(a):

> Index: multilib-minimal.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/multilib-minimal.eclass,v
> retrieving revision 1.9
> diff -u -r1.9 multilib-minimal.eclass
> --- multilib-minimal.eclass 2 May 2014 16:16:37 -0000 1.9
> +++ multilib-minimal.eclass 23 Oct 2014 20:24:23 -0000
> @@ -30,7 +30,7 @@
>  esac
>
>
> -inherit eutils multilib-build
> +inherit eutils multibuild multilib-build
>
>  EXPORT_FUNCTIONS src_configure src_compile src_test src_install
>
> @@ -41,17 +41,14 @@
>   multilib-minimal_abi_src_configure() {
>   debug-print-function ${FUNCNAME} "$@"
>
> - mkdir -p "${BUILD_DIR}" || die
> - pushd "${BUILD_DIR}" >/dev/null || die
>   if declare -f multilib_src_configure >/dev/null ; then
>   multilib_src_configure
>   else
>   default_src_configure
>   fi
> - popd >/dev/null || die

NAK. No real gain in this, while indirection makes the eclass harder to
read.

-- 
Best regards,
Michał Górny