1 |
On Thu, Oct 23, 2014 at 11:08 PM, Michał Górny <mgorny@g.o> wrote: |
2 |
> Dnia 2014-10-23, o godz. 22:31:39 |
3 |
> Davide Pesavento <pesa@g.o> napisał(a): |
4 |
> |
5 |
>> Index: multilib-minimal.eclass |
6 |
>> =================================================================== |
7 |
>> RCS file: /var/cvsroot/gentoo-x86/eclass/multilib-minimal.eclass,v |
8 |
>> retrieving revision 1.9 |
9 |
>> diff -u -r1.9 multilib-minimal.eclass |
10 |
>> --- multilib-minimal.eclass 2 May 2014 16:16:37 -0000 1.9 |
11 |
>> +++ multilib-minimal.eclass 23 Oct 2014 20:24:23 -0000 |
12 |
>> @@ -30,7 +30,7 @@ |
13 |
>> esac |
14 |
>> |
15 |
>> |
16 |
>> -inherit eutils multilib-build |
17 |
>> +inherit eutils multibuild multilib-build |
18 |
>> |
19 |
>> EXPORT_FUNCTIONS src_configure src_compile src_test src_install |
20 |
>> |
21 |
>> @@ -41,17 +41,14 @@ |
22 |
>> multilib-minimal_abi_src_configure() { |
23 |
>> debug-print-function ${FUNCNAME} "$@" |
24 |
>> |
25 |
>> - mkdir -p "${BUILD_DIR}" || die |
26 |
>> - pushd "${BUILD_DIR}" >/dev/null || die |
27 |
>> if declare -f multilib_src_configure >/dev/null ; then |
28 |
>> multilib_src_configure |
29 |
>> else |
30 |
>> default_src_configure |
31 |
>> fi |
32 |
>> - popd >/dev/null || die |
33 |
> |
34 |
> NAK. No real gain in this, while indirection makes the eclass harder to |
35 |
> read. |
36 |
> |
37 |
|
38 |
"run_in_build_dir" sounded fairly easy to read and understand imho... |
39 |
but ok, whatever... I don't really care about this TBH. |
40 |
|
41 |
Best, |
42 |
Davide |