Gentoo Archives: gentoo-dev

From: Ned Ludd <solar@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] dont use `which` in ebuilds
Date: Mon, 12 Mar 2007 23:38:47
Message-Id: 1173742563.13589.64.camel@onyx.private.gni.com
In Reply to: Re: [gentoo-dev] dont use `which` in ebuilds by Mike Frysinger
1 On Mon, 2007-03-12 at 19:15 -0400, Mike Frysinger wrote:
2 > On Monday 12 March 2007, Mike Frysinger wrote:
3 > > instead, since we require bash for our ebuilds, use the builtin `type -p`
4 >
5 > err i botched that ;)
6 >
7 > `type -p` is almost a complete drop in replacement for which ... it does not
8 > work on bash builtins however, so people should use `type -P` to force the
9 > PATH search
10 >
11 > in other words, `type -p echo` would return "" while `type -P echo` would
12 > return "/bin/echo"
13 > -mike
14
15
16 Quick search shows the following ebuilds are abusing this behavior.
17
18 Matches "`which "
19
20 app-dicts/stardict/stardict-2.4.8.ebuild:42:
21 app-emulation/xen-tools/xen-tools-3.0.2-r3.ebuild:57:
22 app-emulation/xen-tools/xen-tools-3.0.2-r4.ebuild:52:
23 media-gfx/quat/quat-1.20.ebuild:26:
24 sci-chemistry/molden/molden-4.3.ebuild:30:
25 sci-libs/blas-atlas/blas-atlas-3.6.0-r1.ebuild:33:
26 sci-libs/blas-atlas/blas-atlas-3.6.0-r2.ebuild:34:
27 sci-libs/blas-atlas/blas-atlas-3.6.0.ebuild:28:
28 sci-libs/lapack-atlas/lapack-atlas-3.6.0.ebuild:64:
29 sci-libs/lapack-reference/lapack-reference-3.0.ebuild:52:
30 sci-mathematics/octave/octave-2.1.57-r1.ebuild:34:
31 sci-mathematics/octave/octave-2.1.69.ebuild:36:
32 www-apps/lxr/lxr-0.3.1.ebuild:37:
33
34 And matches "$(which "
35 app-cdr/cdrkit/cdrkit-1.0.ebuild:26:
36 app-cdr/cdrkit/cdrkit-1.0_pre5.ebuild:30:
37 app-cdr/cdrkit/cdrkit-1.1.0.ebuild:28:
38 app-cdr/cdrkit/cdrkit-1.1.1.ebuild:28:
39 app-cdr/cdrkit/cdrkit-1.1.2.ebuild:28:
40 app-dicts/verbiste/verbiste-0.1.16.ebuild:28:
41 app-text/pdftk/pdftk-1.12.ebuild:20:
42 dev-db/hsqldb/hsqldb-1.7.3.1-r1.ebuild:48:
43 dev-util/kdesvn/kdesvn-0.11.0.ebuild:34:
44 dev-util/kdesvn/kdesvn-0.11.0.ebuild:35:
45 games-emulation/advancemame/advancemame-0.104.0.ebuild:35:
46 games-emulation/advancemame/advancemame-0.104.0.ebuild:37:
47 games-emulation/advancemame/advancemame-0.104.0.ebuild:39:
48 games-emulation/advancemame/advancemame-0.106.0.ebuild:40:
49 games-emulation/advancemame/advancemame-0.106.0.ebuild:42:
50 games-emulation/advancemame/advancemame-0.106.0.ebuild:44:
51 games-emulation/advancemenu/advancemenu-2.4.13.ebuild:42:
52 games-emulation/advancemenu/advancemenu-2.4.13.ebuild:43:
53 games-emulation/advancemenu/advancemenu-2.4.13.ebuild:44:
54 games-fps/doomsday/doomsday-1.9.0_beta5.ebuild:32:
55 games-fps/quake2-icculus/quake2-icculus-0.16.1-r1.ebuild:72:
56 games-fps/quake2-icculus/quake2-icculus-0.16.1.ebuild:51:
57 games-mud/tkmoo/tkmoo-0.3.32.ebuild:32:
58 games-strategy/boson/boson-0.13.ebuild:43:
59 games-strategy/boson/boson-0.13.ebuild:44:
60 media-libs/pdflib/pdflib-5.0.4_p1-r1.ebuild:39:
61 media-libs/pdflib/pdflib-6.0.3-r1.ebuild:48:
62 media-libs/pdflib/pdflib-6.0.3.ebuild:38:
63 sci-geosciences/grass/grass-6.2.0-r1.ebuild:111:
64 sci-geosciences/mapserver/mapserver-4.10.0.ebuild:106:
65 sci-misc/boinc/boinc-4.72.20050813-r3.ebuild:56:
66 sci-misc/boinc/boinc-5.2.14.ebuild:57:
67 sci-misc/boinc/boinc-5.4.11.ebuild:53:
68 sci-misc/boinc/boinc-5.5.6.ebuild:59:
69 sys-process/fcron/fcron-2.0.2.ebuild:28:
70 sys-process/fcron/fcron-2.9.5.1.ebuild:31:
71 sys-process/fcron/fcron-2.9.7.ebuild:26:
72 sys-process/fcron/fcron-3.0.0.ebuild:33:
73 sys-process/fcron/fcron-3.0.1-r1.ebuild:33:
74 sys-process/fcron/fcron-3.0.1.ebuild:33:
75 x11-misc/xoo/xoo-0.7.ebuild:25:
76
77 --
78 Ned Ludd <solar@g.o>
79 Gentoo Linux
80
81 --
82 gentoo-dev@g.o mailing list

Replies

Subject Author
Re: [gentoo-dev] dont use `which` in ebuilds Thomas de Grenier de Latour <degrenier@×××××××××××.fr>
Re: [gentoo-dev] dont use `which` in ebuilds Danny van Dyk <kugelfang@g.o>
Re: [gentoo-dev] dont use `which` in ebuilds Chris Gianelloni <wolf31o2@g.o>
Re: [gentoo-dev] dont use `which` in ebuilds Yuri Vasilevski <yvasilev@g.o>
Re: [gentoo-dev] dont use `which` in ebuilds Andrew Ross <aross@g.o>
Re: [gentoo-dev] dont use `which` in ebuilds Matthias Schwarzott <zzam@g.o>
Re: [gentoo-dev] dont use `which` in ebuilds Lars Weiler <pylon@g.o>