Gentoo Archives: gentoo-dev

From: Danny van Dyk <kugelfang@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] dont use `which` in ebuilds
Date: Tue, 13 Mar 2007 00:38:29
Message-Id: 200703130135.58677.kugelfang@gentoo.org
In Reply to: Re: [gentoo-dev] dont use `which` in ebuilds by Ned Ludd
1 Am Dienstag, 13. März 2007 00:36 schrieb Ned Ludd:
2 > > > instead, since we require bash for our ebuilds, use the builtin
3 > > > `type -p`
4 > >
5 > > err i botched that ;)
6 > >
7 > > `type -p` is almost a complete drop in replacement for which ... it
8 > > does not work on bash builtins however, so people should use `type
9 > > -P` to force the PATH search
10 > >
11 > > in other words, `type -p echo` would return "" while `type -P echo`
12 > > would return "/bin/echo"
13 > > -mike
14 >
15 > Quick search shows the following ebuilds are abusing this behavior.
16 >
17 > Matches "`which "
18 >
19 > sci-chemistry/molden/molden-4.3.ebuild:30:
20 > sci-libs/blas-atlas/blas-atlas-3.6.0-r1.ebuild:33:
21 > sci-libs/blas-atlas/blas-atlas-3.6.0-r2.ebuild:34:
22 > sci-libs/blas-atlas/blas-atlas-3.6.0.ebuild:28:
23 > sci-libs/lapack-atlas/lapack-atlas-3.6.0.ebuild:64:
24 > sci-libs/lapack-reference/lapack-reference-3.0.ebuild:52:
25 > sci-mathematics/octave/octave-2.1.57-r1.ebuild:34:
26 > sci-mathematics/octave/octave-2.1.69.ebuild:36:
27 ^^^ fixed.
28
29 > And matches "$(which "
30 > sci-geosciences/grass/grass-6.2.0-r1.ebuild:111:
31 > sci-geosciences/mapserver/mapserver-4.10.0.ebuild:106:
32 > sci-misc/boinc/boinc-4.72.20050813-r3.ebuild:56:
33 > sci-misc/boinc/boinc-5.2.14.ebuild:57:
34 > sci-misc/boinc/boinc-5.4.11.ebuild:53:
35 > sci-misc/boinc/boinc-5.5.6.ebuild:59:
36 ^^^ fixed as well.
37
38 Danny
39 --
40 Danny van Dyk <kugelfang@g.o>
41 Gentoo/AMD64 Project, Gentoo Scientific Project
42 --
43 gentoo-dev@g.o mailing list