Re: [gentoo-dev] eclass/vdr-plugin-2.eclass EAPI=6 changes, plz review

[Michał Górny]

Since you already committed it with all the todos inside, just
the important thing.

On Sun, 22 May 2016 23:21:59 +0200
Joerg Bornkessel <hd_brummy@g.o> wrote:

> - -   local docfile
> - -   for docfile in README* HISTORY CHANGELOG; do
> - -       [[ -f ${docfile} ]] && dodoc ${docfile}
> +   local commondoc=( README* HISTORY CHANGELOG )
> +   for docfile in "${commondoc[@]}"; do
> +       if [[ ${EAPI} == "6" ]]; then
> +           local DOCS="${DOCS} ${docfile}"
> +           [[ -f ${docfile} ]] && einstalldocs "${DOCS[@]}"
> +       else
> +           [[ -f ${docfile} ]] && dodoc ${docfile}
> +       fi

I have no clue what you're trying to achieve here but following
the EAPI 6 branch, this is what would happen:

| local commondoc=( README* HISTORY CHANGELOG )

1. Let's assume commondoc evaluates to ( README HISTORY CHANGELOG ).

| local DOCS="${DOCS} ${docfile}"

2. If DOCS was an array, you discard all but the first element. But
let's assume it was empty, so it becomes: DOCS=" README".

| [[ -f ${docfile} ]] && einstalldocs "${DOCS[@]}"

3. If README exists, einstalldocs is called. Depending on
the implementation, it will either install all files from DOCS, or fail
because you pass unexpected parameters.

| local DOCS="${DOCS} ${docfile}"

4. Now we have DOCS=" README HISTORY".

| [[ -f ${docfile} ]] && einstalldocs "${DOCS[@]}"

5. HISTORY doesn't exist, so nothing happens.

| local DOCS="${DOCS} ${docfile}"

6. Now we have DOCS=" README HISTORY CHANGELOG".

| [[ -f ${docfile} ]] && einstalldocs "${DOCS[@]}"

7. CHANGELOG exists, so einstalldocs is called to install all *three*
files. It fails because HISTORY that got appended before doesn't exist.


That's one possible scenario. I'm pretty sure you didn't want
einstalldocs here, or needed a special EAPI 6 branch. dodoc still works
as usual.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>