Gentoo Archives: gentoo-dev

From: Joerg Bornkessel <hd_brummy@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] eclass/vdr-plugin-2.eclass EAPI=6 changes, plz review
Date: Sun, 29 May 2016 16:49:43
Message-Id: 574B1D92.7070303@astrali.lan
In Reply to: Re: [gentoo-dev] eclass/vdr-plugin-2.eclass EAPI=6 changes, plz review by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 Am 26.05.2016 um 11:16 schrieb Michał Górny:
5 > Since you already committed it with all the todos inside, just the
6 > important thing.
7 >
8 > On Sun, 22 May 2016 23:21:59 +0200 Joerg Bornkessel
9 > <hd_brummy@g.o> wrote:
10 >
11 >> - - local docfile - - for docfile in README* HISTORY
12 >> CHANGELOG; do - - [[ -f ${docfile} ]] && dodoc ${docfile} +
13 >> local commondoc=( README* HISTORY CHANGELOG ) + for docfile in
14 >> "${commondoc[@]}"; do + if [[ ${EAPI} == "6" ]]; then +
15 >> local DOCS="${DOCS} ${docfile}" + [[ -f ${docfile} ]]
16 >> && einstalldocs "${DOCS[@]}" + else + [[ -f
17 >> ${docfile} ]] && dodoc ${docfile} + fi
18 >
19 > I have no clue what you're trying to achieve ...
20
21
22 Oh please, forget this crap!
23 After rereading einstalldocs, how it works and how is it to handle in
24 .ebuild, here my simple rewrite to integrate it in EAPI=6
25
26 <snipp>
27
28 if [[ ${EAPI} != [45] ]]; then
29 einstalldocs
30 else
31 local docfile
32 for docfile in README* HISTORY CHANGELOG; do
33 [[ -f ${docfile} ]] && dodoc ${docfile}
34 done
35 fi
36
37 </snapp>
38
39 yepp, einstalldocs is supported in EAPI=5 from eutils.eclass too,
40 but i will leave it untached as we use it in this way for EAPI=4,5
41 since long time.
42 So we are save in the existing eapi=4,5 supported ebuilds in the tree.
43
44 Thanks for your review and reply
45
46 Cheers
47
48 /dev/joerg
49
50 - --
51 Joerg Bornkessel <hd_brummy@g.o>
52 GnuPG Key: 0x93EB5F4DAA5832A1
53 Fingerprint: 0E0A A1EE 1DF4 41D7 A3F5 21C2 93EB 5F4D AA58 32A1
54 -----BEGIN PGP SIGNATURE-----
55 Version: GnuPG v2.1
56 Comment: Signed-off-by: Jörg Bornkessel <hd_brummy@g.o>
57
58 iQJ8BAEBCgBmBQJXSx2JXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
59 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwRTBBQTFFRTFERjQ0MUQ3QTNGNTIxQzI5
60 M0VCNUY0REFBNTgzMkExAAoJEJPrX02qWDKhRsIP/3+PiGzWmlWfns0THCVjM2cb
61 xstNG7P+qKSFyWD9tgmSeGLsp590wh8bDBh8LWGfEPayYgal5ps1FeEdSS+syND6
62 fBk8QcBBZlPUSupg4f0sNsOmOguvXDhYz8u9PX2yfbTWAiOSWQcjUyvzU2FascrZ
63 bsCDhpEbDFbjS/vZJs52XCQhxU3WTFzchdn1+87JxDGslyMFe5+DojbDYeJLmkPK
64 9EeZ938PRAuaVNd28fE9A8YbueP59vvtL4oyTab/sWRv/FXsuFJbPlTd2+pOTYWJ
65 EVRvQ9kUiHR+PX3T1m5m8KGa8ZEKR5O/2ibcwI8jlSpOM287/rypujjT+pycpz8A
66 yQ+CF8L8g/SQZRyl3GAYrA/FhHRHXXskbBQOrELk+PywXS/7ccSIV+ySWdawf8UV
67 gItXrWaFZDD6TjG08oXdp5IC1yMh2Vzna7GTPXUoYHJnDp4aZj6ZX0Z+zRRvSIGG
68 MXRYsOMfpPWQOxpczD+oMuC973tv+Psr0c8gisKmK8ZEtdqVj2ZVtRRg/Jig7RhH
69 qAmxMBVhxAYe8m/vSRfJC4zT2GmSZLbFAOKoy5r0Gc5t/PVvHDax2Ku46SpMuWSr
70 gaWOcKTyZC+ynazduEIj4ZNKZhDEWnVx+OjcIVwPDV4cxRiHFVr2tuQK1Un8JXsu
71 8tuGDeoMd24HPEjuD5JA
72 =oSFD
73 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-dev] eclass/vdr-plugin-2.eclass EAPI=6 changes, plz review "Michał Górny" <mgorny@g.o>