1 |
On Sun, 29 May 2016 18:49:22 +0200 |
2 |
Joerg Bornkessel <hd_brummy@g.o> wrote: |
3 |
|
4 |
> -----BEGIN PGP SIGNED MESSAGE----- |
5 |
> Hash: SHA512 |
6 |
> |
7 |
> Am 26.05.2016 um 11:16 schrieb Michał Górny: |
8 |
> > Since you already committed it with all the todos inside, just the |
9 |
> > important thing. |
10 |
> > |
11 |
> > On Sun, 22 May 2016 23:21:59 +0200 Joerg Bornkessel |
12 |
> > <hd_brummy@g.o> wrote: |
13 |
> > |
14 |
> >> - - local docfile - - for docfile in README* HISTORY |
15 |
> >> CHANGELOG; do - - [[ -f ${docfile} ]] && dodoc ${docfile} + |
16 |
> >> local commondoc=( README* HISTORY CHANGELOG ) + for docfile in |
17 |
> >> "${commondoc[@]}"; do + if [[ ${EAPI} == "6" ]]; then + |
18 |
> >> local DOCS="${DOCS} ${docfile}" + [[ -f ${docfile} ]] |
19 |
> >> && einstalldocs "${DOCS[@]}" + else + [[ -f |
20 |
> >> ${docfile} ]] && dodoc ${docfile} + fi |
21 |
> > |
22 |
> > I have no clue what you're trying to achieve ... |
23 |
> |
24 |
> |
25 |
> Oh please, forget this crap! |
26 |
> After rereading einstalldocs, how it works and how is it to handle in |
27 |
> .ebuild, here my simple rewrite to integrate it in EAPI=6 |
28 |
> |
29 |
> <snipp> |
30 |
> |
31 |
> if [[ ${EAPI} != [45] ]]; then |
32 |
> einstalldocs |
33 |
> else |
34 |
> local docfile |
35 |
> for docfile in README* HISTORY CHANGELOG; do |
36 |
> [[ -f ${docfile} ]] && dodoc ${docfile} |
37 |
> done |
38 |
> fi |
39 |
> |
40 |
> </snapp> |
41 |
> |
42 |
> yepp, einstalldocs is supported in EAPI=5 from eutils.eclass too, |
43 |
> but i will leave it untached as we use it in this way for EAPI=4,5 |
44 |
> since long time. |
45 |
> So we are save in the existing eapi=4,5 supported ebuilds in the tree. |
46 |
> |
47 |
> Thanks for your review and reply |
48 |
|
49 |
Yes, this looks good (except for the misindent). Thanks a lot. |
50 |
|
51 |
-- |
52 |
Best regards, |
53 |
Michał Górny |
54 |
<http://dev.gentoo.org/~mgorny/> |