Gentoo Archives: gentoo-dev

From: Thomas Bracht Laumann Jespersen <t@×××××××.xyz>
To: Ulrich Mueller <ulm@g.o>
Cc: gentoo-dev@l.g.o, kernel@g.o, Sam James <sam@g.o>
Subject: Re: [gentoo-dev] [PATCH] linux-info.eclass: Call ebegin, properly close with eend
Date: Wed, 13 Apr 2022 10:03:06
Message-Id: 20220413100247.c4gepzae4fhdfq6m@sofaking
In Reply to: Re: [gentoo-dev] [PATCH] linux-info.eclass: Call ebegin, properly close with eend by Ulrich Mueller
1 > > - einfo "Checking for suitable kernel configuration options..."
2 > > + ebegin "Checking for suitable kernel configuration options..."
3 >
4 > ebegin outputs dots by itself, so the ones in the message should be
5 > removed.
6
7 Good point, will fix... ...
8
9 > > elif [[ ${soft_errors_count} -gt 0 ]]; then
10 > > + eend 0
11 > > ewarn "Please check to make sure these options are set correctly."
12 > > ewarn "Failure to do so may cause unexpected problems."
13 >
14 > Shouldn't this be eend 1, given that there are errors?
15
16 I was back and forth on this. It depends on what's meant by "soft errors" and if
17 they're considered fatal or not, I think. I'll change to "eend 1" for the v2.
18
19 -- Thomas