Gentoo Archives: gentoo-dev

From: Kristian Fiskerstrand <k_f@g.o>
To: gentoo-dev@l.g.o, Mike Frysinger <vapier@g.o>
Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: Add awk wrapper - eawk - edit file in place
Date: Sat, 21 May 2016 16:28:00
Message-Id: 35655227-000b-ae2d-e168-45bdfb569f56@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] eutils.eclass: Add awk wrapper - eawk - edit file in place by "Amadeusz Żołnowski"
1 On 05/21/2016 06:08 PM, Amadeusz Żołnowski wrote:
2 > Mike Frysinger <vapier@g.o> writes:
3 >>> The same "sed -i" is used. I have some configs to edit in place in
4 >>> src_prepare(). It's easier with awk rather than sed.
5 >>
6 >> again, provide an example. one or two uncommon use cases doesn't justify
7 >> being added to eutils.
8 >
9 > See rebar.eclass review where it is used. Later ejabberd ebuild I'm
10 > going to add uses it as well. This function is too generic to be in
11 > rebar.eclass, so I have decided to move it to eutils. What is the
12 > problem with adding it to eutils?
13
14 Is the use-case sufficiently common for it to be sourced in all ebuilds
15 inheriting eutils?
16
17 --
18 Kristian Fiskerstrand
19 OpenPGP certificate reachable at hkp://pool.sks-keyservers.net
20 fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3

Attachments

File name MIME type
signature.asc application/pgp-signature