| 1 |
On 18/11/2017 00:35, Michael Palimaka wrote: |
| 2 |
> On 11/16/2017 02:27 PM, William L. Thomson Jr. wrote: |
| 3 |
>> It maybe worth considering switching the default generator in the |
| 4 |
>> cmake-utils.eclass from the default of emake to ninja. |
| 5 |
>> |
| 6 |
>> - : ${CMAKE_MAKEFILE_GENERATOR:=emake} |
| 7 |
>> + : ${CMAKE_MAKEFILE_GENERATOR:=ninja} |
| 8 |
>> |
| 9 |
>> For those with cmake ebuilds you can test this out now via |
| 10 |
>> |
| 11 |
>> CMAKE_MAKEFILE_GENERATOR="ninja" |
| 12 |
>> inherit cmake-utils |
| 13 |
> If testing this, please use : ${CMAKE_MAKEFILE_GENERATOR:=ninja} in |
| 14 |
> ebuilds unless the emake generator is explicitly known not to work. This |
| 15 |
> will preserve user choice if they want to avoid ninja for some reason. |
| 16 |
> |
| 17 |
In my user opinion this has no place in a ebuild unless upstream clearly |
| 18 |
say to use (or evidently use) ninja as it main generator. |
| 19 |
In cases where ninja is considered (by upstream) the best option, |
| 20 |
Michael suggestion to make it overridable is a very wise one. |
| 21 |
In that case, please also remember to depend on ninja |
| 22 |
|
| 23 |
Since other emails (by Christoph and Brian) in this thread make evident |
| 24 |
that it's not a drop in replacement, fixing it in the eclass seem a bad |
| 25 |
idea, but that probably should be reconsidered when ninja become more |
| 26 |
capable. |
Archives