[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild

[Donnie Berkholz]

On 19:59 Mon 24 Sep     , Matthias Schwarzott (zzam) wrote:
> zzam        07/09/24 19:59:38
>
>   Modified:             ChangeLog
>   Added:                udev-115-r6.ebuild
>   Log:
>   Simplified rules a bit. Let user configure max inode nr of /dev, solving bug #193586.
>   (Portage version: 2.1.3.9)

> 1.1                  sys-fs/udev/udev-115-r6.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/udev/udev-115-r6.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/udev/udev-115-r6.ebuild?rev=1.1&content-type=text/plain

> 	if [[ "${KV_MAJOR}" == 2 ]] && [[ "${KV_MINOR}" == 6 ]] && [[ "${KV_MICRO}" -ge 15 ]]; then
> 	if [[ "$ok" = "0" ]]; then
> 	if [ "${MD5}" != "644e3c77eb866dee4ff8dda2e95cd187" ]
> 	if [[ -f "packages/40-${ARCH}.rules" ]]; then
> 	if [ -h "${ROOT}/etc/hotplug.d/default/udev.hotplug" ]
> 	if [ -h "${ROOT}/etc/hotplug.d/default/05-wait_for_sysfs.hotplug" ]
> 	if [ -h "${ROOT}/etc/hotplug.d/default/10-udev.hotplug" ]
> 	if [ -f "${ROOT}/etc/init.d/coldplug" ]
> 	if [[ ${coldplug_stale} == "1" ]] ; then
> 		if [[ -e "${ROOT}/etc/udev/rules.d/40-scsi-hotplug.rules" ]]
> 	if [[ -d "${ROOT}"/lib/udev/devices ]]; then
> 		if [[ -e "${ROOT}"/etc/udev/rules.d/95-net.rules ]]; then
> 	if [[ -d "${ROOT}"/etc/dev.d ]]; then
> 		if [[ -d "${ROOT}"/etc/dev.d ]]; then
> 		[[ -f "${ROOT}"/etc/udev/rules.d/64-device-mapper.rules ]] &&
> 	if [[ "${ROOT}" == "/" ]] ; then
> 		if [ -r /proc/1/root -a /proc/1/root/ -ef /proc/self/root/ ]; then
> 			if [[ -n $(pidof udevd) ]] ; then
> 	MD5=`md5sum < "${S}/etc/udev/rules.d/50-udev-default.rules"`

This ebuild has really inconsistent use of tests, quotes in tests, and 
command substitutions. Being more consistent will increase readability 
and decrease bugs due to differences between styles. For tests, pick a 
style [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice 
because it generally doesn't require quotes, so the code looks a lot 
cleaner. For command substitions, prefer $() over ``.

> 	newins ${FILESDIR}/blacklist-110 blacklist
> 	doins ${FILESDIR}/pnp-aliases

Quotes here.

> 	emake \
> 		EXTRAS="${extras}" \
> 		libudevdir=${udev_helper_dir} \
> 		CROSS_COMPILE=${mycross} \
> 		OPTFLAGS="" \
> 		${myconf} || die

> 	emake \
> 		DESTDIR="${D}" \
> 		libudevdir=${udev_helper_dir} \
> 		EXTRAS="${extras}" \
> 		${myconf} \
> 		install || die

Could use some die messages here.

Thanks,
Donnie
-- 
gentoo-dev@g.o mailing list