| 1 |
On 21.09.15 02:53, Fernando Rodriguez wrote: |
| 2 |
> On Monday, September 21, 2015 12:00:28 AM James Le Cuirot wrote: |
| 3 |
>> On Sun, 20 Sep 2015 18:54:24 -0400 |
| 4 |
>> Fernando Rodriguez <frodriguez.developer@×××××××.com> wrote: |
| 5 |
>> |
| 6 |
>>> On Sunday, September 20, 2015 11:33:34 PM James Le Cuirot wrote: |
| 7 |
>>>> On Sun, 20 Sep 2015 17:53:25 -0400 |
| 8 |
>>>> Fernando Rodriguez <frodriguez.developer@×××××××.com> wrote: |
| 9 |
>>>> |
| 10 |
>>>>> On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote: |
| 11 |
>>>>>> Dnia 2015-09-18, o godz. 20:09:16 |
| 12 |
>>>>>> Fernando Rodriguez <frodriguez.developer@×××××××.com> |
| 13 |
>>>>>> napisał(a): |
| 14 |
>>>>>> |
| 15 |
>>>>>>> Github allows editting of comments in pull requests. Is there |
| 16 |
>>>>>>> a policy regarding that? I've noticed a comment disappear |
| 17 |
>>>>>>> which makes the rest of the |
| 18 |
>>>>>>> conversation seem out of place. |
| 19 |
>>>>>> |
| 20 |
>>>>>> We can't really do anything about that. However, we might soon |
| 21 |
>>>>>> be mirroring all comments on Bugzilla where removing comments |
| 22 |
>>>>>> is not permitted. |
| 23 |
>>>>> |
| 24 |
>>>>> I realize you can't control how users use that feature but there |
| 25 |
>>>>> should be some policy about how developers use it. I opened at PR |
| 26 |
>>>>> because I was asked in bugzilla. I received some suggestions to |
| 27 |
>>>>> which I replied that most of them are not related to my PR but |
| 28 |
>>>>> will still do them. After I pushed the changes the comment making |
| 29 |
>>>>> the suggestions gets deleted. |
| 30 |
>>>> |
| 31 |
>>>> They are probably not deleted but merely hidden. There should be a |
| 32 |
>>>> "Show outdated diff" link that will reveal them. |
| 33 |
>>> |
| 34 |
>>> Are you refering to the "Show Obsolete" link on Bugzilla? I'm talking |
| 35 |
>>> about deleted comments on Github. I can't find anyway to show them. |
| 36 |
>> |
| 37 |
>> No, I do mean GitHub. I believe deleted comments really do get deleted |
| 38 |
>> but the ones that seemingly disappear when you amend a commit just get |
| 39 |
>> hidden. See this pull request as an example. |
| 40 |
>> |
| 41 |
>> https://github.com/chef-cookbooks/enterprise-chef-common/pull/25 |
| 42 |
>> |
| 43 |
>> Notice the grey "Show outdated diff" links on right right. |
| 44 |
> |
| 45 |
> I was refering to actual comments, but that's another annoyance. I think that |
| 46 |
> link is only shown when somebody references the commit. Mine just disappear |
| 47 |
> when I amend a commit. Maybe the QA bot could reference every commit. |
| 48 |
> |
| 49 |
|
| 50 |
I was curious too about what's an "outdated diff" and why I don't see |
| 51 |
those in my pull requests after amending and doing "git push -f", so I |
| 52 |
wrote to GitHub support and here's what they replied: |
| 53 |
|
| 54 |
>> Can you explain me what an outdated diff is? |
| 55 |
> |
| 56 |
> If you comment on a file that was changed as part of a certain pull |
| 57 |
> request, and then that file changes again as a result of new commits |
| 58 |
> made to the PR's branch, the diff you commented on is now outdated. |
| 59 |
> For example: |
| 60 |
> |
| 61 |
> File A say: |
| 62 |
> Heres a diif! |
| 63 |
> |
| 64 |
> And you comment saying "You're missing an apostrophe!" |
| 65 |
> |
| 66 |
> And then the user changes File A to say: |
| 67 |
> Here's a diff! |
| 68 |
> |
| 69 |
> Then your comment is now outdated since it was on a file that has |
| 70 |
> since been updated. |
| 71 |
> |
| 72 |
> Hope that was clear! |
Archives