| 1 |
On Monday, September 21, 2015 12:00:28 AM James Le Cuirot wrote: |
| 2 |
> On Sun, 20 Sep 2015 18:54:24 -0400 |
| 3 |
> Fernando Rodriguez <frodriguez.developer@×××××××.com> wrote: |
| 4 |
> |
| 5 |
> > On Sunday, September 20, 2015 11:33:34 PM James Le Cuirot wrote: |
| 6 |
> > > On Sun, 20 Sep 2015 17:53:25 -0400 |
| 7 |
> > > Fernando Rodriguez <frodriguez.developer@×××××××.com> wrote: |
| 8 |
> > > |
| 9 |
> > > > On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote: |
| 10 |
> > > > > Dnia 2015-09-18, o godz. 20:09:16 |
| 11 |
> > > > > Fernando Rodriguez <frodriguez.developer@×××××××.com> |
| 12 |
> > > > > napisał(a): |
| 13 |
> > > > > |
| 14 |
> > > > > > Github allows editting of comments in pull requests. Is there |
| 15 |
> > > > > > a policy regarding that? I've noticed a comment disappear |
| 16 |
> > > > > > which makes the rest of the |
| 17 |
> > > > > > conversation seem out of place. |
| 18 |
> > > > > |
| 19 |
> > > > > We can't really do anything about that. However, we might soon |
| 20 |
> > > > > be mirroring all comments on Bugzilla where removing comments |
| 21 |
> > > > > is not permitted. |
| 22 |
> > > > |
| 23 |
> > > > I realize you can't control how users use that feature but there |
| 24 |
> > > > should be some policy about how developers use it. I opened at PR |
| 25 |
> > > > because I was asked in bugzilla. I received some suggestions to |
| 26 |
> > > > which I replied that most of them are not related to my PR but |
| 27 |
> > > > will still do them. After I pushed the changes the comment making |
| 28 |
> > > > the suggestions gets deleted. |
| 29 |
> > > |
| 30 |
> > > They are probably not deleted but merely hidden. There should be a |
| 31 |
> > > "Show outdated diff" link that will reveal them. |
| 32 |
> > |
| 33 |
> > Are you refering to the "Show Obsolete" link on Bugzilla? I'm talking |
| 34 |
> > about deleted comments on Github. I can't find anyway to show them. |
| 35 |
> |
| 36 |
> No, I do mean GitHub. I believe deleted comments really do get deleted |
| 37 |
> but the ones that seemingly disappear when you amend a commit just get |
| 38 |
> hidden. See this pull request as an example. |
| 39 |
> |
| 40 |
> https://github.com/chef-cookbooks/enterprise-chef-common/pull/25 |
| 41 |
> |
| 42 |
> Notice the grey "Show outdated diff" links on right right. |
| 43 |
|
| 44 |
I was refering to actual comments, but that's another annoyance. I think that |
| 45 |
link is only shown when somebody references the commit. Mine just disappear |
| 46 |
when I amend a commit. Maybe the QA bot could reference every commit. |
| 47 |
|
| 48 |
-- |
| 49 |
Fernando Rodriguez |
Archives