1 |
On Sun, 24 Feb 2013 05:22:43 +0100 |
2 |
hasufell <hasufell@g.o> wrote: |
3 |
|
4 |
> Before people start asking I should explain why I started this: |
5 |
> https://bugs.gentoo.org/show_bug.cgi?id=458638 |
6 |
> |
7 |
> I think having such an eclass has several advantages over |
8 |
> autootools-multilib.eclass (which depends on autotools-utils.eclass) as |
9 |
> it is now: |
10 |
|
11 |
You wanted the other points, so here you go. |
12 |
|
13 |
> a) Less eclass dependencies. One could argue: the more eclasses my |
14 |
> ebuild uses the more prone to error and exposed to changes it is. |
15 |
|
16 |
That's as good as bundling libraries. Really. |
17 |
|
18 |
> b) easier conversion in some cases: often times a simple rename |
19 |
> src_compile -> multilib_src_compile will do |
20 |
|
21 |
Easy != good. The eclass switch is a good point to fix bugs which |
22 |
should have been fixed long ago. By making it unnecessary, you just |
23 |
keep those bugs live and hidden. |
24 |
|
25 |
> c) it allows more custom definition of phase functions |
26 |
|
27 |
More custom than what? |
28 |
|
29 |
> d) the previous point will also allow to convert go-mono.eclass packages |
30 |
> without introducing yet another eclass for that |
31 |
|
32 |
So you're introducing a hacky eclass just because you're too lazy to |
33 |
convert go-mono packages properly and too impatient to let others do |
34 |
the work properly for you? |
35 |
|
36 |
> e) autotools-utils.eclass does a bit more than just calling default |
37 |
> phase functions; the developer has little choice on this matter unless |
38 |
> he wants to rewrite his ebuild based on multilib-build.eclass which will |
39 |
> create a lot of code duplication in ebuilds, hence this proposition |
40 |
|
41 |
And as I already told you, this argument just proves that you don't |
42 |
know the eclass in question and just throwing random accusations. |
43 |
|
44 |
> I don't have a problem with the present eclasses, but I find this a |
45 |
> logical enhancement. |
46 |
|
47 |
If that's logical, then please provide a graph showing where it |
48 |
logically fits. Because so far, it's either hate-built redundant eclass |
49 |
or quick draft eclass written for a single package. |
50 |
|
51 |
-- |
52 |
Best regards, |
53 |
Michał Górny |