Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH git-r3 09/10] Add EGIT_MIN_CLONE_TYPE to support ebuilds requiring greater clone type.
Date: Thu, 27 Feb 2014 00:23:55
Message-Id: 530E858F.40605@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH git-r3 09/10] Add EGIT_MIN_CLONE_TYPE to support ebuilds requiring greater clone type. by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 Michał Górny:
5 > Dnia 2014-02-26, o godz. 23:53:22 hasufell <hasufell@g.o>
6 > napisał(a):
7 >
8 >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
9 >>
10 >> Micha? Górny:
11 >>> Use-cases include Google Code (that doesn't support shallow
12 >>> clones) and random build systems that play with history and
13 >>> 'git describe'.
14 >>>
15 >>> However, please use this sparingly. When the build can't go on
16 >>> without non-shallow clone, sure. But if it only results in
17 >>> non-pretty versions, I think users choosing
18 >>> EGIT_CLONE_TYPE=shallow explicitly are ready to deal with the
19 >>> fallout.
20 >>
21 >> Afaiu EGIT_MIN_CLONE_TYPE is not something the user should mess
22 >> with. Can we make that more clear somehow? I already see related
23 >> bug reports by people doing weird things in make.conf.
24 >>
25 >> Or even developers mixing these two up.
26 >
27 > I assumed 'supported by the ebuild' implies it's for ebuild to set.
28 > But I can make it explicit, sure.
29 >
30
31 Thanks for your work.
32 -----BEGIN PGP SIGNATURE-----
33
34 iQEcBAEBCgAGBQJTDoWPAAoJEFpvPKfnPDWzNz4H/Rjm3tImvgw9dVbdeBOFh4lQ
35 l4lhHDtvM7vNJirChGogZIZUOm8hWSoGEZ2qfjZtFpm8Ywvbt1cbgKllOlUYMyOP
36 ZPciTMmhfRiFAYkiVF1B2xcvKCeJufKiXPcm8iVUEQ3Q6sZ4doNSnXEW/un3MH4E
37 h69H1FG21A+ZRcdc5jA0ETrT/bojODrqLuDwe6eMEuXVpAlpnQFA7KPZK3ZOq7dr
38 d5gOtC6gPGr5HjWNp31w1QmzKrAqUGTdrmWW8vgvK4daufWjxKuj0+K4SEjfsNQk
39 lB+AM+c7D58SvTy57Ey8GKv8QhVO6PSR1zty8bTzoCms6pvIf3DqNf6PJjOzd04=
40 =oBmI
41 -----END PGP SIGNATURE-----