Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: hasufell@g.o
Subject: Re: [gentoo-dev] [PATCH git-r3 09/10] Add EGIT_MIN_CLONE_TYPE to support ebuilds requiring greater clone type.
Date: Thu, 27 Feb 2014 00:10:39
Message-Id: 20140227010937.5d22ff90@pomiot.lan
In Reply to: Re: [gentoo-dev] [PATCH git-r3 09/10] Add EGIT_MIN_CLONE_TYPE to support ebuilds requiring greater clone type. by hasufell
1 Dnia 2014-02-26, o godz. 23:53:22
2 hasufell <hasufell@g.o> napisał(a):
3
4 > -----BEGIN PGP SIGNED MESSAGE-----
5 > Hash: SHA512
6 >
7 > Micha? Górny:
8 > > Use-cases include Google Code (that doesn't support shallow clones)
9 > > and random build systems that play with history and 'git
10 > > describe'.
11 > >
12 > > However, please use this sparingly. When the build can't go on
13 > > without non-shallow clone, sure. But if it only results in
14 > > non-pretty versions, I think users choosing EGIT_CLONE_TYPE=shallow
15 > > explicitly are ready to deal with the fallout.
16 >
17 > Afaiu EGIT_MIN_CLONE_TYPE is not something the user should mess with.
18 > Can we make that more clear somehow? I already see related bug reports
19 > by people doing weird things in make.conf.
20 >
21 > Or even developers mixing these two up.
22
23 I assumed 'supported by the ebuild' implies it's for ebuild to set. But
24 I can make it explicit, sure.
25
26 --
27 Best regards,
28 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies