Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH git-r3 09/10] Add EGIT_MIN_CLONE_TYPE to support ebuilds requiring greater clone type.
Date: Wed, 26 Feb 2014 23:53:41
Message-Id: 530E7E72.9050709@gentoo.org
In Reply to: [gentoo-dev] [PATCH git-r3 09/10] Add EGIT_MIN_CLONE_TYPE to support ebuilds requiring greater clone type. by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 Micha? Górny:
5 > Use-cases include Google Code (that doesn't support shallow clones)
6 > and random build systems that play with history and 'git
7 > describe'.
8 >
9 > However, please use this sparingly. When the build can't go on
10 > without non-shallow clone, sure. But if it only results in
11 > non-pretty versions, I think users choosing EGIT_CLONE_TYPE=shallow
12 > explicitly are ready to deal with the fallout.
13
14 Afaiu EGIT_MIN_CLONE_TYPE is not something the user should mess with.
15 Can we make that more clear somehow? I already see related bug reports
16 by people doing weird things in make.conf.
17
18 Or even developers mixing these two up.
19 -----BEGIN PGP SIGNATURE-----
20
21 iQEcBAEBCgAGBQJTDn5yAAoJEFpvPKfnPDWzXSAH/jeogFcURQvW8/wOpd0Ejd5X
22 vkX/g0nhwJj7+q4t9FHOtvhw95KvaMvqd7t5G11SRKu/RqgfvjN2RdnfPAAaYIuZ
23 oQ04gopmHvuTxEF/FOrWv0aJ5oF9f2bpxesnsSgSRI4SVIeII9sjHyPowEOS+NH4
24 i1HPaMFG3OitI0yHBOFAqGhbPoNjNPrb2n3UVMUFnrM5bPZnj6MDUyFhc1p35fjt
25 BVT7WWvDH6wKg0pYuHj6bPK6zyQAADYKF0VZOMfw+4UadWT7iGfjJE68JGW4Dm9s
26 HUDqDg/Kda4Jexb/U2DoIpwXrKU79K7aUxSxUSTKV7UqSV+BmJpsGcVsddMJgu4=
27 =NnXq
28 -----END PGP SIGNATURE-----

Replies