Gentoo Archives: gentoo-dev

From: David Michael <fedora.dm0@×××××.com>
To: Ulrich Mueller <ulm@g.o>
Cc: gentoo-dev@l.g.o, "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH 3/4] acct-group.eclass: EAPI 8 support
Date: Tue, 22 Jun 2021 18:00:46
Message-Id: CAEvUa7==GaSuLrF+Jnee2cqKw8kxAm4iPCp5wc2p8xiByAqWBQ@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH 3/4] acct-group.eclass: EAPI 8 support by Ulrich Mueller
1 On Tue, Jun 22, 2021 at 1:15 PM Ulrich Mueller <ulm@g.o> wrote:
2 > >>>>> On Tue, 22 Jun 2021, David Michael wrote:
3 > > -# Then you add appropriate dependency to your package. The dependency
4 > > -# type(s) should be:
5 > > -# - DEPEND (+ RDEPEND) if the group is already needed at build time,
6 > > -# - RDEPEND if it is needed at install time (e.g. you 'fowners' files
7 > > -# in pkg_preinst) or run time.
8 >
9 > "man acct-group.eclass" currently renders that paragraph like this:
10 >
11 > Then you add appropriate dependency to your package. The dependency
12 > type(s) should be: - DEPEND (+ RDEPEND) if the group is already needed
13 > at build time, - RDEPEND if it is needed at install time (e.g. you
14 > 'fowners' files
15 > in pkg_preinst) or run time.
16 >
17 > In other words, there's very little formatting support in eclassdoc.
18 >
19 > > +# Then you add appropriate dependencies to your package. Note that the build
20 > > +# system might need to resolve names, too. The dependency type(s) should be:
21 > > +# - BDEPEND if the group must be resolvable at build time (e.g. it is used by
22 > > +# 'fowners' in src_install),
23 > > +# - IDEPEND if it must be resolvable at install time (e.g. it is used by
24 > > +# 'fowners' in pkg_preinst),
25 > > +# - RDEPEND in every case.
26 >
27 > So, while at it, could you reformat it that it will be better readable
28 > in the generated man page?
29 >
30 > (Same issue in acct-user.eclass.)
31
32 I made these changes and pushed the commits to
33 https://github.com/gentoo/gentoo/pull/21377 in case that's easier to
34 track changes and merge. I could resend everything if that's
35 preferred.
36
37 Thanks.
38
39 David