Gentoo Archives: gentoo-dev

From: Alex Legler <a3li@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: gems.eclass review
Date: Thu, 12 Mar 2009 20:02:31
Message-Id: 1236888142.13104.6.camel@localhost
In Reply to: [gentoo-dev] Re: gems.eclass review by Ryan Hill
1 On Fr, 2009-03-06 at 21:03 -0600, Ryan Hill wrote:
2 > In the case that USE_RUBY is set to something funky, it never gets handled. The eclass
3 > basically just does nothing. This might be what you want, but if not, how about something
4 > like:
5 >
6
7 Actually, this is what we want. ;)
8 I noticed after I sent the eclass for review, that USE_RUBY="any" should
9 not be used anymore. So I added a deprecation notice and will get rid of
10 it in a month or so.
11
12 > > + dodir ${GEMSDIR}
13 >
14 > || die
15 >
16
17 Added the two die's, thanks.
18
19 I also added eclass-manpages-style documentation and empty EAPI-2
20 functions to make pva happy. :p
21
22 I am going to wait another couple of days before comitting if anyone
23 should have more comments. Updated the old URLs with the new changes:
24
25 http://dev.gentoo.org/~a3li/ruby/gems.eclass.txt
26 http://dev.gentoo.org/~a3li/ruby/gems.eclass.diff
27
28 Thanks,
29 Alex

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Re: gems.eclass review Peter Volkov <pva@g.o>