| 1 |
On Sat, 17 Jun 2006, Thomas Cort wrote: |
| 2 |
|
| 3 |
> What is the proper quoting style for using epatch? In the tree there |
| 4 |
> are about 3 different styles... |
| 5 |
> |
| 6 |
> epatch ${FILESDIR}/some-fix.patch # used by 7326 ebuilds |
| 7 |
> epatch "${FILESDIR}"/some-fix.patch # used by 3092 ebuilds |
| 8 |
> epatch "${FILESDIR}/some-fix.patch" # used by 1434 ebuilds |
| 9 |
|
| 10 |
The second and third are fine. The quoting is needed since FILESDIR |
| 11 |
is user-set and could contain a space. |
| 12 |
|
| 13 |
> What is the proper quoting style for defining the S variable? In the |
| 14 |
> tree there are about 3 different styles... |
| 15 |
> |
| 16 |
> S=${WORKDIR}/${MY_P} # used by 5270 ebuilds |
| 17 |
> S="${WORKDIR}"/${MY_P} # used by 43 ebuilds |
| 18 |
> S="${WORKDIR}/${MY_P}" # used by 2259 ebuilds |
| 19 |
|
| 20 |
The first is correct. The second and third have unnecessary quoting. |
| 21 |
|
| 22 |
Michael Sterrett |
| 23 |
-Mr. Bones.- |
| 24 |
mr_bones_@g.o |
| 25 |
-- |
| 26 |
gentoo-dev@g.o mailing list |
Archives