| 1 |
On Sun, Sep 14, 2014 at 05:40:30PM +0200, Michał Górny wrote: |
| 2 |
> Dnia 2014-09-15, o godz. 03:15:14 Kent Fredric napisał(a): |
| 3 |
> > Only downside there is the way github pull reqs work is if the |
| 4 |
> > final SHA1's that hit tree don't match, the pull req doesn't |
| 5 |
> > close. |
| 6 |
> > |
| 7 |
> > Solutions: |
| 8 |
> > |
| 9 |
> > - A) Have somebody tasked with reaping old pull reqs with |
| 10 |
> > permissions granted. ( Uck ) |
| 11 |
> > - B) Always use a merge of some kind to mark the pull req as dead |
| 12 |
> > ( for instance, an "ours" merge to mark the branch as deprecated ) |
| 13 |
> > |
| 14 |
> > Both of those options are kinda ugly. |
| 15 |
> |
| 16 |
> If you merge a pull request, I suggest doing a proper 'git merge -S' |
| 17 |
> anyway to get a developer signature on top of all the changes. |
| 18 |
|
| 19 |
Some previous package-tree-in-Git efforts suggested that only |
| 20 |
Gentoo-dev signatures were acceptable, and that those signatures would |
| 21 |
be required on every commit (not just the first-parent line) [1,2]. I |
| 22 |
don't see the point of that, so long as Gentoo devs are signing the |
| 23 |
first-parent line, but if folks still want Gentoo-dev signatures on |
| 24 |
every commit the ‘git merge -S’ approach will not work for closing |
| 25 |
PRs. |
| 26 |
|
| 27 |
Cheers, |
| 28 |
Trevor |
| 29 |
|
| 30 |
[1]: http://article.gmane.org/gmane.linux.gentoo.devel/77572 |
| 31 |
id:CAGfcS_maNfikeVTj3cmcQ1OF-uQAVEbE2r1oKykYGwC5VOmvfw@××××××××××.com |
| 32 |
[2]: https://bugs.gentoo.org/show_bug.cgi?id=502060#c0 |
| 33 |
|
| 34 |
-- |
| 35 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
| 36 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |
Archives