1 |
On Sat, Sep 15, 2012 at 8:59 AM, Michał Górny <mgorny@g.o> wrote: |
2 |
> On Fri, 14 Sep 2012 19:43:42 -0400 |
3 |
> "Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> wrote: |
4 |
> |
5 |
>> On 09/14/2012 05:27 PM, Michał Górny wrote: |
6 |
>> > On Fri, 14 Sep 2012 17:18:16 -0400 |
7 |
>> > "Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> wrote: |
8 |
>> > |
9 |
>> >> -----BEGIN PGP SIGNED MESSAGE----- |
10 |
>> >> Hash: SHA1 |
11 |
>> >> |
12 |
>> >> On 09/14/2012 04:56 PM, Ciaran McCreesh wrote: |
13 |
>> >>> On Fri, 14 Sep 2012 16:51:54 -0400 |
14 |
>> >>> "Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> wrote: |
15 |
>> >>>> I have a personal vendetta on this subject. Several eclasses set |
16 |
>> >>>> a completely worthless description (and even more set a mostly |
17 |
>> >>>> worthless DESCRIPTION) which ends up contaminating the |
18 |
>> >>>> DESCRIPTION for an ebuild when inherit is done after DESCRIPTION |
19 |
>> >>>> is set. |
20 |
>> >>> |
21 |
>> >>> http://article.gmane.org/gmane.linux.gentoo.devel/78813/ |
22 |
>> >>> |
23 |
>> >>>> I realize that most of you will find this a little pedantic, |
24 |
>> >>>> however, I find that needing to move my DESCRIPTION to below the |
25 |
>> >>>> inherit often severely affects the readability of the ebuild, and |
26 |
>> >>>> all to avoid a completely (or nearly) worthless DESCRIPTION from |
27 |
>> >>>> contaminating my environment. |
28 |
>> >>> |
29 |
>> >>> You want your inherit line to be as near as the top as possible. |
30 |
>> >>> The only things you should have before the inherit line are EAPI |
31 |
>> >>> and any variables used by eclasses to determine behaviour. |
32 |
>> >>> |
33 |
>> >>> |
34 |
>> >> I have a nasty habit of writing ebuilds to be both live and |
35 |
>> >> versioned which requires me to test ${PV} then set things like |
36 |
>> >> inherit VCS, SRC-URI, and KEYWORDS below. The large if block |
37 |
>> >> looks better in my opinion below the settings which are the same |
38 |
>> >> for all versions, rather than in the middle. |
39 |
>> >> |
40 |
>> >> Yes, it's a readability issue, but the point is, this shouldn't be |
41 |
>> >> an issue at all. |
42 |
>> > |
43 |
>> > Use unifdef. Look at my overlay, and my ebuilds in the tree. |
44 |
>> > |
45 |
>> |
46 |
>> So just so we are clear, everyone but me thinks that |
47 |
>> DESCRIPTION="Based on the ${ECLASS} eclass" is a completely useful |
48 |
>> and critically required piece of code? |
49 |
> |
50 |
> No. We agree with you that it is useless but you are saying that with |
51 |
> a *completely* wrong reasoning. |
52 |
> |
53 |
>> Until that point I'll probably keep bringing this up. |
54 |
> |
55 |
> Don't forget to threaten us that you'll leave Gentoo. |
56 |
> |
57 |
> -- |
58 |
> Best regards, |
59 |
> Michał Górny |
60 |
|
61 |
This was uncalled-for. I see no such tone from his e-mails. We need no |
62 |
more flames. We had enough of these already. |
63 |
|
64 |
-- |
65 |
Regards, |
66 |
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2 |