| 1 |
On Fri, 14 Sep 2012 19:43:42 -0400 |
| 2 |
"Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> wrote: |
| 3 |
|
| 4 |
> On 09/14/2012 05:27 PM, Michał Górny wrote: |
| 5 |
> > On Fri, 14 Sep 2012 17:18:16 -0400 |
| 6 |
> > "Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> wrote: |
| 7 |
> > |
| 8 |
> >> -----BEGIN PGP SIGNED MESSAGE----- |
| 9 |
> >> Hash: SHA1 |
| 10 |
> >> |
| 11 |
> >> On 09/14/2012 04:56 PM, Ciaran McCreesh wrote: |
| 12 |
> >>> On Fri, 14 Sep 2012 16:51:54 -0400 |
| 13 |
> >>> "Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> wrote: |
| 14 |
> >>>> I have a personal vendetta on this subject. Several eclasses set |
| 15 |
> >>>> a completely worthless description (and even more set a mostly |
| 16 |
> >>>> worthless DESCRIPTION) which ends up contaminating the |
| 17 |
> >>>> DESCRIPTION for an ebuild when inherit is done after DESCRIPTION |
| 18 |
> >>>> is set. |
| 19 |
> >>> |
| 20 |
> >>> http://article.gmane.org/gmane.linux.gentoo.devel/78813/ |
| 21 |
> >>> |
| 22 |
> >>>> I realize that most of you will find this a little pedantic, |
| 23 |
> >>>> however, I find that needing to move my DESCRIPTION to below the |
| 24 |
> >>>> inherit often severely affects the readability of the ebuild, and |
| 25 |
> >>>> all to avoid a completely (or nearly) worthless DESCRIPTION from |
| 26 |
> >>>> contaminating my environment. |
| 27 |
> >>> |
| 28 |
> >>> You want your inherit line to be as near as the top as possible. |
| 29 |
> >>> The only things you should have before the inherit line are EAPI |
| 30 |
> >>> and any variables used by eclasses to determine behaviour. |
| 31 |
> >>> |
| 32 |
> >>> |
| 33 |
> >> I have a nasty habit of writing ebuilds to be both live and |
| 34 |
> >> versioned which requires me to test ${PV} then set things like |
| 35 |
> >> inherit VCS, SRC-URI, and KEYWORDS below. The large if block |
| 36 |
> >> looks better in my opinion below the settings which are the same |
| 37 |
> >> for all versions, rather than in the middle. |
| 38 |
> >> |
| 39 |
> >> Yes, it's a readability issue, but the point is, this shouldn't be |
| 40 |
> >> an issue at all. |
| 41 |
> > |
| 42 |
> > Use unifdef. Look at my overlay, and my ebuilds in the tree. |
| 43 |
> > |
| 44 |
> |
| 45 |
> So just so we are clear, everyone but me thinks that |
| 46 |
> DESCRIPTION="Based on the ${ECLASS} eclass" is a completely useful |
| 47 |
> and critically required piece of code? |
| 48 |
|
| 49 |
No. We agree with you that it is useless but you are saying that with |
| 50 |
a *completely* wrong reasoning. |
| 51 |
|
| 52 |
> Until that point I'll probably keep bringing this up. |
| 53 |
|
| 54 |
Don't forget to threaten us that you'll leave Gentoo. |
| 55 |
|
| 56 |
-- |
| 57 |
Best regards, |
| 58 |
Michał Górny |
Archives