Re: [gentoo-dev] [PATCH 2/2] xorg-2.eclass: Remove XORG_STATIC

[David Seifert]

On Fri, 2021-01-08 at 23:16 -0500, Matt Turner wrote:
> Statically linking X libraries into your program is an extremely bad
> idea.
>
> Signed-off-by: Matt Turner <mattst88@g.o>
> ---
>  eclass/xorg-2.eclass | 23 +----------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)
>
> diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
> index f3b282e1a11..f9a18b8ec26 100644
> --- a/eclass/xorg-2.eclass
> +++ b/eclass/xorg-2.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2020 Gentoo Authors
> +# Copyright 1999-2021 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  # @ECLASS: xorg-2.eclass
> @@ -168,27 +168,6 @@ fi
>  # If we're a driver package, then enable DRIVER case
>  [[ ${PN} == xf86-video-* || ${PN} == xf86-input-* ]] && DRIVER="yes"
>  
> -# @ECLASS-VARIABLE: XORG_STATIC
> -# @DESCRIPTION:
> -# Enables static-libs useflag. Set to no, if your package gets:
> -#
> -# QA: configure: WARNING: unrecognized options: --disable-static
> -: ${XORG_STATIC:="yes"}
> -
> -# Add static-libs useflag where useful.
> -if [[ ${XORG_STATIC} == yes \
> -               && ${FONT} != yes \
> -               && ${CATEGORY} != app-doc \
> -               && ${CATEGORY} != x11-apps \
> -               && ${CATEGORY} != x11-drivers \
> -               && ${CATEGORY} != media-fonts \
> -               && ${PN} != util-macros \
> -               && ${PN} != xbitmaps \
> -               && ${PN} != xorg-cf-files \
> -               && ${PN/xcursor} = ${PN} ]]; then
> -       IUSE+=" static-libs"
> -fi
> -
>  DEPEND+=" virtual/pkgconfig"
>  
>  # @ECLASS-VARIABLE: XORG_DRI

+1 LGTM.