Gentoo Archives: gentoo-dev

From: Serkan Kaba <serkan@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Please avoid absolute paths in patched filenames
Date: Tue, 18 Nov 2008 04:50:00
Message-Id: 49224971.8080800@gentoo.org
In Reply to: Re: [gentoo-dev] Please avoid absolute paths in patched filenames by Mart Raudsepp
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Mart Raudsepp yazmış:
5 > On Mon, 2008-11-17 at 20:24 +0100, Diego 'Flameeyes' Pettenò wrote:
6 >> I ask it here as a favour, please avoid using absolute paths in the
7 >> filenames of patched files. This mean avoid having stuff like
8 >>
9 >> --- foobar/foo.c
10 >> +++ /tmp/foobar/foobar.c
11 >>
12 >> This tends to break from time to time, and I had to fix at least three
13 >> packages since I started my treewide build for these problems. I already
14 >> asked Zac about adding such a check on repoman, but in the mean time I'd
15 >> like to ask here for people to verify their packages.
16 >>
17 >> I actually am culprit of doing this some time ago but I learnt my lesson
18 >> the hard way :P My suggestion for everybody else is to use quilt when
19 >> you need to write patches.
20 >>
21 >> And if you have patches with the filenames like I shown above, you can
22 >> change it the git way so that it becomes:
23 >>
24 >> --- a/foobar/foo.c
25 >> +++ b/foobar/foo.c
26 >>
27 >> and the problem is usually solved.
28 >
29 > Could you please expand on what the actual problem is for reference,
30 > having never seen them fail myself or hear any fail for others?
31 >
32 >
33
34 See bug #237667 and dev-thread
35 http://archives.gentoo.org/gentoo-dev/msg_777d416bb082a45b0e4848d8db5bfec8.xml
36
37 - --
38 Sincerely,
39 Serkan KABA
40 Gentoo/Java
41 -----BEGIN PGP SIGNATURE-----
42 Version: GnuPG v2.0.9 (GNU/Linux)
43 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
44
45 iEYEARECAAYFAkkiSXEACgkQRh6X64ivZaJfgACfbA/wjlEoldGyZUaDev0jXyng
46 /SkAoIHS1c8x2bAHbeFDO+r4M8NIK++R
47 =+Ho/
48 -----END PGP SIGNATURE-----