| 1 |
On 15/05/16 23:55, Duncan wrote: |
| 2 |
> Daniel Campbell posted on Sun, 15 May 2016 04:04:57 -0700 as excerpted: |
| 3 |
> |
| 4 |
>> If the dev in question hasn't done that before, then it's entirely |
| 5 |
>> possible they *thought* they tested, or tested it *before* making some |
| 6 |
>> other edit and absent-mindedly committed. |
| 7 |
> Again, legacy CVS thought pattern. In git, commit != push, and it's the |
| 8 |
> push that's critical. |
| 9 |
> |
| 10 |
> Commit all you want without testing. Just test (and fix if necessary) |
| 11 |
> before you push those commits up to the gentoo master repo. =:^) |
| 12 |
> |
| 13 |
> (Of course, rebasing to fold the broken commit and its fix into one |
| 14 |
> before pushing doesn't hurt, either.) |
| 15 |
> |
| 16 |
Surely it should be possible to fire some QA scripts on pre-commit on |
| 17 |
the central gentoo repos (ie. at the push target end)?! |
| 18 |
Or am I being a bit optimistic .. |
Archives