Re: [gentoo-dev] vala.eclass: change vala_src_prepare behavior when USE=-vala

[Michał Górny]

On Wed, 19 Sep 2012 21:42:35 +0100
Ciaran McCreesh <ciaran.mccreesh@××××××××××.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Wed, 19 Sep 2012 16:33:13 -0400
> Ian Stakenvicius <axs@g.o> wrote:
> > On 19/09/12 03:37 PM, Ciaran McCreesh wrote:
> > > On Wed, 19 Sep 2012 15:26:44 -0400 Alexandre Rostovtsev
> > > <tetromino@g.o> wrote:
> > >> Pacho Ramos has suggested making vala_src_prepare() into a no-op
> > >> in the common situation where vala is in IUSE and USE=-vala.
> > >
> > > There's no way to obtain the effective value of IUSE from within
> > > an ebuild or eclass. You'll need to use an independent variable to
> > > get this information.
> > >
> >
> > I don't think that the 'effective' value of IUSE matters in this
> > particular case.  This would be the 'explicit' value as is
> > hard-coded in the ebuild that would need to be checked against, I
> > expect?
> >
> > Unless eclasses and phase functions are in the habit of removing
> > entries from IUSE, I don't see this being an issue?
>
> No, you're not guaranteed to get the ebuild's value of IUSE, or any
> particular eclass's value of IUSE, or the merged value of IUSE. In
> particular for this case, it's possible to get false negatives.

Then fix the spec.

-- 
Best regards,
Michał Górny