Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o, Ulrich Mueller <ulm@g.o>
Cc: Pacho Ramos <pacho@g.o>
Subject: Re: [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Do not inherit eutils.
Date: Sun, 20 Dec 2015 11:06:31
Message-Id: 1783221F-BFB3-46E8-ABB6-392BAE827B9D@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Do not inherit eutils. by Ulrich Mueller
1 Dnia 20 grudnia 2015 11:31:58 CET, Ulrich Mueller <ulm@g.o> napisał(a):
2 >>>>>> On Sun, 20 Dec 2015, Michał Górny wrote:
3 >
4 >> Feel free to use $'\0' if that makes it more explicit for you.
5 >
6 >This is even worse. The null character cannot be passed as an argument
7 >because it is the string terminator. No, I won't use the "read"
8 >variant at all, because it is an unreadable and gross hack.
9 >
10 >Besides, the "set -f" code in the eclass works just fine and has been
11 >tested for several years by now.
12
13 Sure. Relying on implicit word splitting which is a side effect of unquoted variable use, along with disabling side effects of that use is not a hack. On the other hand, using built-in dedicated to word splitting is. Of course.
14
15 While at it, please make sure to remove all uses of 'find -print0' hack. I'm pretty sure you can find some implicit ugly side effect that could allow us to do the same after mangling a few shopts.
16
17 >
18 >Ulrich
19
20
21 --
22 Best regards,
23 Michał Górny (by phone)

Replies