| 1 |
>>>>> On Sun, 20 Dec 2015, Michał Górny wrote: |
| 2 |
|
| 3 |
>> Besides, the "set -f" code in the eclass works just fine and has |
| 4 |
>> been tested for several years by now. |
| 5 |
|
| 6 |
> Sure. Relying on implicit word splitting which is a side effect of |
| 7 |
> unquoted variable use, along with disabling side effects of that use |
| 8 |
> is not a hack. On the other hand, using built-in dedicated to word |
| 9 |
> splitting is. Of course. |
| 10 |
|
| 11 |
> While at it, please make sure to remove all uses of 'find -print0' |
| 12 |
> hack. I'm pretty sure you can find some implicit ugly side effect |
| 13 |
> that could allow us to do the same after mangling a few shopts. |
| 14 |
|
| 15 |
So, you don't get things exactly in your style, and then other dev's |
| 16 |
code is an "ugly hack" and uses "side effects". Even if the code in |
| 17 |
question causes no problems whatsoever and uses standard well |
| 18 |
documented shell features. |
| 19 |
|
| 20 |
I think we should end this discussion here. Let the eclass maintainer |
| 21 |
decide what approach (if any) he wants to adopt. |
| 22 |
|
| 23 |
Ulrich |
Archives