1 |
On Sat, Mar 29, 2014 at 09:27:18PM +0100, Francisco Blas Izquierdo Riera (klondike) wrote: |
2 |
> Hi! |
3 |
> |
4 |
> El 29/03/14 05:13, Samuli Suominen escribió: |
5 |
> > I took the liberty to unbreak the tree for you. Don't ever touch my |
6 |
> > packages again unless |
7 |
> > they are broken. |
8 |
> Udev is broken: |
9 |
> * They have known off by one string handling errors on their libraries, |
10 |
> the developers were warned of that but have chosen to ignore the issue. |
11 |
> The issue is still on |
12 |
> http://cgit.freedesktop.org/systemd/systemd/tree/src/shared/strxcpyx.c |
13 |
> on the function size_t strpcpyf(char **dest, size_t size, const char |
14 |
> *src, ...) which can overflow the string boundaries in some case. This |
15 |
> issue keeps coming up from time to time thanks to their "nice" efforts |
16 |
> for cahnging the whole thing instead of fixing bugs. Also after a year |
17 |
> nothing has been done. |
18 |
|
19 |
I must have missed it, where was this reported? |
20 |
|
21 |
And where is the off-by-one issue here? What am I missing in the code? |
22 |
|
23 |
> * They keep losing cohesion |
24 |
> (http://en.wikipedia.org/wiki/Cohesion_%28computer_science%29) by |
25 |
> inserting more and more unrelated software into Udev/systemd. This helps |
26 |
> things like the above happen again. |
27 |
|
28 |
That has nothing to do with a logic bug. |
29 |
|
30 |
> * They have the bad habit of recoding functions that are already |
31 |
> provided by their only supported c library. This helps things like the |
32 |
> above happen.ç |
33 |
|
34 |
Where are these functions in glibc that should have been used instead? |
35 |
|
36 |
greg k-h |