Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Underscores in USE flags
Date: Fri, 20 Sep 2019 16:55:48
Message-Id: 20e57b194284c4d20e6781573fd0387257aed9f1.camel@gentoo.org
In Reply to: Re: [gentoo-dev] Underscores in USE flags by Mike Gilbert
1 On Fri, 2019-09-20 at 12:41 -0400, Mike Gilbert wrote:
2 > On Fri, Sep 20, 2019 at 12:11 PM Michał Górny <mgorny@g.o> wrote:
3 > > On Fri, 2019-09-20 at 11:46 -0400, Mike Gilbert wrote:
4 > > > Recently, a large number of bugs were filed against packages that have
5 > > > USE flag names which contain underscores. Apparently PMS prohibits
6 > > > this except when the USE flag is part of a USE_EXPAND variable.
7 > > >
8 > > > https://projects.gentoo.org/pms/7/pms.html#x1-200003.1.4
9 > > >
10 > > > I'm not certain when this text was added to PMS, or how many of the
11 > > > affected USE flags pre-date this policy.
12 > > >
13 > > > Portage seems to have no issue dealing with underscores, so this
14 > > > doesn't seem to be solving any technical problem.
15 > > >
16 > > > I am pretty sure that renaming a bunch of USE flags will cause some
17 > > > amount of end-user confusion, for very little benefit. Is enforcing
18 > > > this part of PMS really worth it?
19 > >
20 > > And having packages with pretended-USE_EXPAND-that-does-not-work-as-
21 > > USE_EXPAND is less confusing to the users?
22 >
23 > I doubt users immediately think "USE_EXPAND" when they see an underscore.
24 >
25 > Portage's seems fairly unambiguous to me. For example:
26 >
27 > % emerge -pv1O app-misc/foo
28 >
29 > These are the packages that would be merged, in order:
30 >
31 > [ebuild N ] app-misc/foo-0::local USE="-modern_kernel"
32 > PYTHON_TARGETS="python3_7" VIDEO_CARDS="radeon" 0 KiB
33 >
34 > Total: 1 package (1 new), Size of downloads: 0 KiB
35 >
36 > I don't think anyone would mistake "modern_kernel" for a USE_EXPAND
37 > value given the above.
38 >
39
40 Look at the humongous list of flags on dev-libs/aws-sdk-cpp. They all
41 start with 'aws_targets' which is a clear attempt to emulate USE_EXPAND.
42 Expect that they won't work as USE_EXPAND, user typing:
43
44 AWS_TARGETS="foo bar baz"
45
46 will just wildly confused, and in the end this prefixing is just silly
47 and causes the flag names to become awfully long.
48
49 --
50 Best regards,
51 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Underscores in USE flags Mike Gilbert <floppym@g.o>