Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH 1/1] linux-info.eclass: Provide ability to skip CONFIG_* checks
Date: Sat, 06 Aug 2022 02:12:38
Message-Id: CAJ0EP42x+hBh+ArrwKA4PPNFrsjur_Nxdf1ndsdG1c-jo0d58Q@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH 1/1] linux-info.eclass: Provide ability to skip CONFIG_* checks by Ionen Wolkens
1 On Fri, Aug 5, 2022 at 7:15 PM Ionen Wolkens <ionen@g.o> wrote:
2 >
3 > On Fri, Aug 05, 2022 at 06:47:42PM -0400, Mike Pagano wrote:
4 > > Based upon code from check-reqs.eclass by Andreas Sturmlechner
5 > >
6 > > Provide support for users who requested the ability to skip
7 > > CONFIG_* checks. (e.g. from within a chroot for testing purposes)
8 > >
9 > > Bug: https://bugs.gentoo.org/862315
10 > > Signed-off-by: Mike Pagano <mpagano@g.o>
11 > > ---
12 > > eclass/linux-info.eclass | 11 ++++++++++-
13 > > 1 file changed, 10 insertions(+), 1 deletion(-)
14 > >
15 > > diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
16 > > index 7e130062a..59e86490f 100644
17 > > --- a/eclass/linux-info.eclass
18 > > +++ b/eclass/linux-info.eclass
19 > > @@ -29,6 +29,15 @@
20 > > # A Couple of env vars are available to effect usage of this eclass
21 > > # These are as follows:
22 > >
23 > > +
24 > > +# @ECLASS_VARIABLE: CHECKCONFIG_DONOTHING
25 > > +# @USER_VARIABLE
26 > > +# @DEFAULT_UNSET
27 > > +# @DESCRIPTION:
28 > > +# Do not error out in check_extra_config if CONFIG settings are not met.
29 > > +# This is a user flag and should under _no circumstances_ be set in the ebuild.
30 > > +[[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] && CHECKCONFIG_DONOTHING=1
31 >
32 > So this enables it if I_KNOW_WHAT_I_AM_DOING is set?
33 >
34 > Generally I feel giving more purposes to that variable is a bad idea.
35 > What starts out as "don't bother me about size/ram checks" ignores
36 > a lot of other things that may be not be expected.
37
38 I agree. Please avoid abusing the I_KNOW_WHAT_I_AM_DOING variable any further.

Replies