| 1 |
On 8/5/22 22:12, Mike Gilbert wrote: |
| 2 |
> On Fri, Aug 5, 2022 at 7:15 PM Ionen Wolkens <ionen@g.o> wrote: |
| 3 |
>> |
| 4 |
>> On Fri, Aug 05, 2022 at 06:47:42PM -0400, Mike Pagano wrote: |
| 5 |
>>> Based upon code from check-reqs.eclass by Andreas Sturmlechner |
| 6 |
>>> |
| 7 |
>>> Provide support for users who requested the ability to skip |
| 8 |
>>> CONFIG_* checks. (e.g. from within a chroot for testing purposes) |
| 9 |
>>> |
| 10 |
>>> Bug: https://bugs.gentoo.org/862315 |
| 11 |
>>> Signed-off-by: Mike Pagano <mpagano@g.o> |
| 12 |
>>> --- |
| 13 |
>>> eclass/linux-info.eclass | 11 ++++++++++- |
| 14 |
>>> 1 file changed, 10 insertions(+), 1 deletion(-) |
| 15 |
>>> |
| 16 |
>>> diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass |
| 17 |
>>> index 7e130062a..59e86490f 100644 |
| 18 |
>>> --- a/eclass/linux-info.eclass |
| 19 |
>>> +++ b/eclass/linux-info.eclass |
| 20 |
>>> @@ -29,6 +29,15 @@ |
| 21 |
>>> # A Couple of env vars are available to effect usage of this eclass |
| 22 |
>>> # These are as follows: |
| 23 |
>>> |
| 24 |
>>> + |
| 25 |
>>> +# @ECLASS_VARIABLE: CHECKCONFIG_DONOTHING |
| 26 |
>>> +# @USER_VARIABLE |
| 27 |
>>> +# @DEFAULT_UNSET |
| 28 |
>>> +# @DESCRIPTION: |
| 29 |
>>> +# Do not error out in check_extra_config if CONFIG settings are not met. |
| 30 |
>>> +# This is a user flag and should under _no circumstances_ be set in the ebuild. |
| 31 |
>>> +[[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] && CHECKCONFIG_DONOTHING=1 |
| 32 |
>> |
| 33 |
>> So this enables it if I_KNOW_WHAT_I_AM_DOING is set? |
| 34 |
>> |
| 35 |
>> Generally I feel giving more purposes to that variable is a bad idea. |
| 36 |
>> What starts out as "don't bother me about size/ram checks" ignores |
| 37 |
>> a lot of other things that may be not be expected. |
| 38 |
> |
| 39 |
> I agree. Please avoid abusing the I_KNOW_WHAT_I_AM_DOING variable any further. |
| 40 |
> Baldino |
| 41 |
|
| 42 |
|
| 43 |
I actually agree. I was following the pattern that did not receive any complaints on the mailing list when presented for the other eclass indicated. |
| 44 |
|
| 45 |
It's a vague variable and this adds more random functionality when set. |
| 46 |
|
| 47 |
I'll change this appropriately and submit something later today. |
| 48 |
|
| 49 |
Thanks for thee review. |
| 50 |
|
| 51 |
Mike |
| 52 |
|
| 53 |
|
| 54 |
|
| 55 |
|
| 56 |
-- |
| 57 |
Mike Pagano |
| 58 |
Gentoo Developer - Kernel Project |
| 59 |
Gentoo Sources - Lead |
| 60 |
E-Mail : mpagano@g.o |
| 61 |
GnuPG FP : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137 |
| 62 |
Public Key : http://http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index |
Archives